Skip to content

Warning indicates probable bug in nf90_open handling of cache_preemption #146

Closed

Description

We have this warning:

netcdf4_func.f90:84:27:

           preemption_out = cache_preemption
                           1
Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1) [-Wconversion]
netcdf4_func.f90:39:27:

           preemption_out = cache_preemption
                           1
Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1) [-Wconversion]
netcdf_text_variables.f90:60:93:

      localMap   (:numDims  ) = (/ 1, (product(localCount(:counter)), counter = 1, numDims - 1) /)
                                                                                             1
Warning: DO loop at (1) will be executed zero times [-Wzerotrip]
netcdf_attributes.f90:221:17:

     valuesA(1) = values
                 1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
netcdf4_file.f90:49:25:

         preemption_out = cache_preemption
                         1
Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1) [-Wconversion]
netcdf4_func.f90:783:75:

When I look at the code I see that we are simply casting the real to the integer preemption. However I believe this should be multiplied by 100 first.

I will check this out next time I take a look at netcdf-fortran, but I've just put up a PR and I will wait til that gets merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions