Fix H5FD_class_t problems #3237
Merged
+32
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Issue Unidata#3202 ## Primary Change The notion of versioning H5FD_class_t was introduced publicly in hdf5-1.13.2. This seems to conflict with some documentation that says it was 1.10.0. This latter value found its way into H5FDhttp.c. As a result, there is a discrepancy in libhdf5/H5FDhttp.c. Note that this should address the above issue in part. So, the fixes: 1. Regularize this the version testing to be hdf5 version 1.13.2. 2. Use the correct H5FD_class_t fields depending on the hdf5 version. ## Secondary Change I noted a problem with the definition of strndup when compiling with C++. Since strndup is defined for C++, I made the strndup decl be conditional on not C++.
WardF
requested changes
Dec 29, 2025
Member
WardF
left a comment
WardF
left a comment
There was a problem hiding this comment.
This looks good and is more comprehensive than the fix I was making (which got derailed with the Github CI issues I pivoted towards). Once the link in the release notes is fixed we can get it merged in :). Thanks!
WardF
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Change
The notion of versioning H5FD_class_t was introduced publicly in hdf5-1.13.2. This seems to conflict with some documentation that says it was 1.10.0. This latter value found its way into H5FDhttp.c. As a result, there is a discrepancy in libhdf5/H5FDhttp.c. Note that this should address the above issue in part.
So, the fixes:
Secondary Change
I noted a problem with the definition of strndup when compiling with C++. Since strndup is defined for C++, I made the strndup decl be conditional on not C++.