fix declarative contour plotting of global data #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgoebber
force-pushed
the
fix_global_contours
branch
from
37c02f3 to
41190b1
Compare
dopplershift
approved these changes
Apr 13, 2021
Member
|
Ignoring unrelated link failure from test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This change modifies the declarative syntax to fix an issue with global contours that wrapped around the globe. It appears that there was multiple transformations happening for global lat/lon data that was causing the problem. A new test (and test data) have been added to check for plotting global GFS one degree data from a Northern Hemispheric projection.
There should not be any change to the input longitudes and having them in 0 to 360 is desired. The area setting though needs to be -180 to 180 for data that begins at the International dateline.
This resolves an issue a user reported when attempting to plot global one degree GFS output.
Checklist