Refactor parse_cf to not modify coordinates inplace#1285
Merged
dopplershift merged 2 commits intoUnidata:masterfrom Jan 12, 2020
jthielen:parse-cf-refactor
Merged
Refactor parse_cf to not modify coordinates inplace#1285dopplershift merged 2 commits intoUnidata:masterfrom jthielen:parse-cf-refactor
dopplershift merged 2 commits intoUnidata:masterfrom
jthielen:parse-cf-refactor
Conversation
dopplershift
added
Area: Xarray
dopplershift
previously approved these changes
Jan 12, 2020
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
I like the implementation approach taken here. Very clean to assemble the new coords and assign once.
Member
|
I'll rebase and merge. |
Member
|
Oh, no this was already up to date. The test failure was real, failing with our oldest supported xarray. It looks like |
Member
|
Ignoring Codacy and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Refactors
parse_cfto not modify coordinates (which may be tied to immutable indexes) inplace, and instead reassign the coordinates in the recommended way. If this goes as my tests locally lead me to believe, this should fix the issues created with xarray in pydata/xarray#3519.Checklist
addednot modified