Skip to content

v2.0 - Alpha version - bug list #744

Open
@arxeiss

Description

@arxeiss

And provide the followings :

  • Operating system :Windows (development) / Linux (production)
  • Laravel version : 5.7
  • Package version : 2.0-alpha7

I just used your package v2.0 and found many little problems. I don't want to create one issue for each little bug. So here is the list

Bugs:

  • config - url_prefix - does not apply if you use package routes. Only in demo
  • If I select file, I cannot deselect it by clicking somewhere else. So I cannot upload file, because that button dissapear
  • If I use alphanumeric_directory I cannot rename file, because there is a dot and you are checking it in RenameController:29 no matte if you are renaming file or folder
  • Really big problem is Exceptions. You are throwing them but are never catched. Or if they are, you change them into ErrorBag and log them. Which is really bad, becuase all of them are ending in my Sentry. Examples: User is trying to upload file, which is not allowed. Throw exception and end up in Sentry...

Improvements:

  • If alphanumeric_filename is set to true, you just replace all non-alphanumeric filenames by _. Rather to use Laravel Str::ascii() to remove those accents into their ASCII relative
  • If there is no window.opener or window.parent hide button to Use file if is selected. Because button does not work anyway

Thanks a lot, I will put Pull request with Czech translation soon

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBehaviors that do not meet expectation.enhancementOptimization for existing features.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions