Scrollbar accent color bugfix [#570] #608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CustomRecyclerView naming is generic. Changing the name to something meaningful is suggested. LeafPicRecyclerView sounds nice and we can use it throughout the app for better customisation. |
Member
|
@Techydevil well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quick fix around for changing the scrollbar color was to use an XML linking to a drawable. However, this couldn't be used as a solution in our case since the drawable XML wouldn't link to a dynamic color code that changes when the user changes the accent-color.
Hence I've created a custom recycler view class that overrides the default drawing of the scrollbar, changing it's color to the color set in settings by accessing "accent_color_preference" with the help of Hawk. Hope this fixes it.