Skip to content

Fix incorrect behavior in SvcSplitScreen #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UncraftedName merged 1 commit into from
Feb 10, 2026
Merged

Fix incorrect behavior in SvcSplitScreen #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions DemoParser/src/Parser/Components/Messages/SvcSplitScreen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,28 @@

namespace DemoParser.Parser.Components.Messages {

// format is grabbed from p2 dissasembly + strike protobuf messages
public class SvcSplitScreen : DemoMessage {

public bool RemoveUser;
private BitStreamReader _data;
public BitStreamReader Data => _data.FromBeginning(); // todo
public int Slot;
public int PlayerIndex;


public SvcSplitScreen(SourceDemo? demoRef, byte value) : base(demoRef, value) {}


protected override void Parse(ref BitStreamReader bsr) {
RemoveUser = bsr.ReadBool();
uint dataLen = bsr.ReadUInt(11);
_data = bsr.ForkAndSkip((int)dataLen);
Slot = bsr.ReadBool() ? 1 : 0;
PlayerIndex = bsr.ReadSInt(DemoInfo.MaxEdictBits);
}


public override void PrettyWrite(IPrettyWriter pw) {
pw.AppendLine(RemoveUser ? "remove user" : "add user");
pw.Append($"data of length {Data.BitLength}");
pw.AppendLine($"slot: {Slot}");
pw.Append($"player index: {PlayerIndex}");
}
}
}
Loading