Refactor #6
Merged
Refactor #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work. Closes #5. |
UnchartedBull
added a commit
that referenced
this pull request
Mar 29, 2021
* feature/tasmota (#6) * add tasmota plugin power options * add Tasmota MQTT plugin support * update install script for power plugins * Bump lottie-web from 5.7.6 to 5.7.7 (#1587) * Update scripts urls in docs files (#1585) * Bump @typescript-eslint/parser from 4.18.0 to 4.19.0 (#1589) * Bump @typescript-eslint/eslint-plugin from 4.18.0 to 4.19.0 (#1590) * Fix a few small bugs (#1588) * fix websocket and config upgrade bug (#1594) * cache animations (#1595) * fix formatting * update idx to index and relayN to relayNumber Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Jc Miñarro <josecarlos.minarro@gmail.com> Co-authored-by: Timon G <timon.gaebelein@icloud.com>
pciavald
pushed a commit
to pciavald/OctoDash
that referenced
this pull request
May 12, 2021
* feature/tasmota (UnchartedBull#6) * add tasmota plugin power options * add Tasmota MQTT plugin support * update install script for power plugins * Bump lottie-web from 5.7.6 to 5.7.7 (UnchartedBull#1587) * Update scripts urls in docs files (UnchartedBull#1585) * Bump @typescript-eslint/parser from 4.18.0 to 4.19.0 (UnchartedBull#1589) * Bump @typescript-eslint/eslint-plugin from 4.18.0 to 4.19.0 (UnchartedBull#1590) * Fix a few small bugs (UnchartedBull#1588) * fix websocket and config upgrade bug (UnchartedBull#1594) * cache animations (UnchartedBull#1595) * fix formatting * update idx to index and relayN to relayNumber Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Jc Miñarro <josecarlos.minarro@gmail.com> Co-authored-by: Timon G <timon.gaebelein@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code into single components to make it easier to create the touchscreen interface. This should also enable me to do both (touchscreen and non-touchscreen) via a config flag.
Just needs some final testing before merging