Add sdcard support #563
Add sdcard support #563
Conversation
|
That looks quite impressing. Currently on mobile, I’ll make sure to check this out in detail tomorrow! |
| <span *ngIf="job.hasOwnProperty('estimatedPrintTime') && job.hasOwnProperty('estimatedEndTime')"> | ||
| <fa-icon [icon]="['fas', 'clock']" class="job-info__print-details-icon"></fa-icon> | ||
| <span class="job-info__print-details-value"> | ||
| {{ job.estimatedPrintTime.value }}{{ job.estimatedPrintTime.unit }} | ||
| </span> | ||
| <span class="job-info__print-details-finish-state"> | ||
| - will finish ~{{ job.estimatedEndTime }} | ||
| </span> | ||
| <br /> | ||
| </span> | ||
| <br /> | ||
| <fa-icon [icon]="['fas', 'dharmachakra']" class="job-info__print-details-icon"></fa-icon> | ||
| <span class="job-info__print-details-value"> | ||
| {{ job.filamentAmount }}g | ||
| </span> | ||
| <span class="job-info__print-details-finish-state"> | ||
| filament will be used | ||
| <span *ngIf="job.hasOwnProperty('filamentAmount')"> | ||
| <fa-icon [icon]="['fas', 'dharmachakra']" class="job-info__print-details-icon"></fa-icon> | ||
| <span class="job-info__print-details-value"> | ||
| {{ job.filamentAmount }}g | ||
| </span> | ||
| <span class="job-info__print-details-finish-state"> | ||
| filament will be used | ||
| </span> |
There was a problem hiding this comment.
this will just be a big empty space if no GCode Analysis is available right?
There was a problem hiding this comment.
yes, it just hides the estimated completion time and filament weight required since they aren't available, which does leave quite a bit of empty space.
|
Just noticed this when searching issues for "printing with sd card". I am printing some stuff now from SD card because I now think I get better print quality on fast prints (due to the limitations of the serial interface between pi and printer). I get a constant flashing error dialog stating "Can't retrieve job status", and another message pops up very briefly while it is doing this. I recorded it with my phone in slow motion and figured out that it states "can't retrieve thumbnail" in this short bursts. Will this fix this issue? |
|
Note: It also messes up formatting of the temps and fan speed. because it says "sd" at the bottom. |
|
Yes should do, that issue was first fixed in #542 and then this PR refines that a bit further. Both merged after v1.4.1 though so you should get the fixes in the next release. Though I didn't get any issues with the 'printing from sd' message when testing on the official raspberry pi touchscreen. Could you create a new issue for that please, including which screen you are using and its resolution and/or aspect ratio if known, so we can look into that a bit more. |
|
Sure - here is the info on my screen: |
|
I had another issue post with this same screen before (regarding the temperature formatting being "off" when bed temp was 100 or higher). |
Adds more complete support for browsing/printing from the sdcard in octodash.
If there are files available from both local and sdcard, then a fake top level folder is shown to select between local and sdcard. Browsing inside those folders then continues as normal and the path starts with either '/local' or '/sdcard'.
If there are only local or sdcard files, then only the relevant folder is shown. For example if sdcard support is not enabled in octoprint, then you will just see a list of local files as usual. Only difference is the path would now show '/local' at the start instead of '/'. Browsing up to '/' is prevented to keep the user confined to local files.
Also cleans up some of the changes in my previous sdcard commit (#542). Rather than passing through null values to the view, if certain values are not available then they are simply not added to the object. The view then checks if the property exists before displaying certain elements that may not always be available.
Resolves #481