Adds thumbnail preview for UltimakerFormatPackage plugin support #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnchartedBull
requested changes
Mar 2, 2020
There was a problem hiding this comment.
I really like your OctoPrint plugin (so you just got a new user 👍). The Cura renderings actually fit really well into the color scheme and it makes the detail view so much nicer.
Also like your thinking with the integration. I just would like to move as much logic away from the html, as the html should remain as dump as possible. So just some minor changes, otherwise really good code! Thanks!
If you're fine with my suggestions / come up with another solution, which removes logic from the frontend, this can be merged and will be included in the next release.
Co-Authored-By: Timon G. <timon.gaebelein@icloud.com>
Co-Authored-By: Timon G. <timon.gaebelein@icloud.com>
|
Suggested changes are fine with me and have been committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #170, I have hacked together a quick fix for file preview when used in conjunction with my UltimakerFormatPackage plugin.