Feature: Glanceable UI theme + additional progress percentage. #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filament screen corrected with the following changes: * Filament bar background colour changed to match theme. * Filament table background gradient removed. * Filament bar width adjusted to match files section, this also lined up the scroll bar with its background.
Addition of a second progress percentage which is attached to the progress bar div. CSS set to make this percentage hidden by default. This will allow the creation of themes where percentage is visible for both round and straight progress bars.
Theme creates a horizontal progress bar when printing that is more easily readable from across the room. This theme requires the additional div from the previous commit, but the instructions in the Readme.md include a workaround.
|
Very curiously it appears it's trying to remerge c2822a2... I don't understand why since the lines it wants to merge are already part of the NOX theme. Also please excuse the "Merge branch 'master' " messages. It took me a while to realise that Visual Studio Code wasn't rebasing. Let me know if you want me to nuke this completely and start again or if this is able to be merged... |
|
Should work now without an additional percentage diff. Let me know if everything works as you expect. |
UnchartedBull
approved these changes
Nov 4, 2020
|
Cheers I'll have a look tonight if this achieved what was intended. |
thegarbz
commented
Nov 5, 2020
|
Yeah I also just learned about that selector a week or so ago. |
kantlivelong
pushed a commit
to kantlivelong/OctoDash
that referenced
this pull request
May 5, 2021
…rtedBull#1151) * Updated Filament in Theme. Filament screen corrected with the following changes: * Filament bar background colour changed to match theme. * Filament table background gradient removed. * Filament bar width adjusted to match files section, this also lined up the scroll bar with its background. * Progress Percentage Added Addition of a second progress percentage which is attached to the progress bar div. CSS set to make this percentage hidden by default. This will allow the creation of themes where percentage is visible for both round and straight progress bars. * New Theme: "Glanceable" Theme creates a horizontal progress bar when printing that is more easily readable from across the room. This theme requires the additional div from the previous commit, but the instructions in the Readme.md include a workaround. * Cleaned up whitespace at EOL * remove third percentage div * Slightly move percentage in progress bar to left. Co-authored-by: UnchartedBull <timon.gaebelein@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further addresses issue #749 for a more progress centric UI.
It includes a new "Glanceable" theme which is a variant on the standard theme but with a horizontal progress bar.
Additionally a second progress percentage element has been added to the app nested with the horizontal progress bar. This allows a progress percentage to be visible and in two different places on the screen depending on which progress bar is shown. The CSS is setup to ensure this second progress bar is hidden unless enabled by a theme.
This change was tested against both the default theme as well as the NOX theme to ensure it doesn't break either.