Skip to content

Commit

Permalink
Broaden google-cloud-core dependency (feast-dev#2094)
Browse files Browse the repository at this point in the history
* Broaden google-cloud-core dependency

Limiting google-cloud-core to 1.4.* seems tighter than it needs to be. The version 1.7.2 (which is the latest before 2.0.0) passes tests and makes feast more interoperable as a library with other systems.

Signed-off-by: Pamela Toman <ptoman@paloaltonetworks.com>

* Distinguish signing and signing off commits in contrib guidance

Signed-off-by: Pamela Toman <ptoman@paloaltonetworks.com>
  • Loading branch information
ptoman-pa authored Dec 2, 2021
1 parent e6ed3cb commit c7d0b10
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,17 @@ pre-commit install --hook-type pre-commit --hook-type pre-push
```
3. On push, the pre-commit hook will run. This runs `make format` and `make lint`.

### Signing commits
Use git signing to sign your commits. See
### Signing off commits
Use git signoffs to sign your commits. See
https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification for details

Then, you can sign commits with the `-s` flag:
Then, you can sign off commits with the `-s` flag:
```
git commit -s -m "My first commit"
```

GPG-signing commits with `-S` is optional.

### Incorporating upstream changes from master
Our preference is the use of `git rebase [master]` instead of `git merge` : `git pull -r`.

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"google-cloud-bigquery-storage >= 2.0.0",
"google-cloud-datastore>=2.1.*",
"google-cloud-storage>=1.34.*,<1.41",
"google-cloud-core==1.4.*",
"google-cloud-core>=1.4.0,<2.0.0",
]

REDIS_REQUIRED = [
Expand Down

0 comments on commit c7d0b10

Please sign in to comment.