Skip to content

Use Assert.Equal in calculator example tests #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

Arash-Sabet
Copy link
Contributor

Summary

  • replace Assert.True comparisons with Assert.Equal

Testing

  • dotnet test examples/Xunit.Microsoft.DependencyInjection.ExampleTests (fails: dotnet command not found)

https://chatgpt.com/codex/tasks/task_e_689d407259648333af521a9ecc408ff6

Copilot

This comment was marked as outdated.

@Arash-Sabet Arash-Sabet requested a review from Copilot August 14, 2025 01:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves test assertion clarity by replacing Assert.True comparisons with Assert.Equal in calculator example tests. This change provides better test failure messages and follows xUnit best practices for equality assertions.

  • Replaced Assert.True(expected == calculatedValue) with Assert.Equal(expected, calculatedValue) in two test methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Arash-Sabet Arash-Sabet merged commit 212f4c9 into main Aug 14, 2025
2 checks passed
@Arash-Sabet Arash-Sabet deleted the codex/update-assertions-in-calculatortests branch August 14, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant