Major Version Should Have Been Incremented

[mstortz]

Hello! Just my opinion, but when a significant change is made to a supporting library, like XUnit V2 to V3, perhaps a major version number increment is in order. The 9.06 version breaks those projects still on XUnit v2. (Ask me how I know!)

[Arash-Sabet]

@mstortz Please suggest the version number. Does 9.1.0 sound fair? Please let me know how it broke your projects.

[Arash-Sabet]

@ChrisDoernen I merged your PR after fixing the test order issue and released ver 9.0.6. Are you experiencing any issues? Thanks.

[mstortz]

Sorry, should have been more specific. Since I'm using XUnit 2.9.3 (v2) and not XUnit 2.0.3 (v3), the compiler became confused about where to locate ITestOutputHelper. My code was (correctly) getting from XUnit.Abstractions, but it has moved in 2.0.3 to xunit,v3.core, so code that referred to getting dependencies (which is where I imagine xunit-dependency-injection comes in) could not located it. I should probably put together an example.

[ChrisDoernen]

@Arash-Sabet no issues with the code changes but @mstortz issue is what I meant with my comment in the PR regarding versioning.

I also suggest incrementing the major version and putting a section in the readme that version 10 is only to be used with xUnit.v3 packages.

Maybe version 9.0.6 can even be unlisted on Nuget.org to prevent further confusion.

What do you think?

I also could have been more explicit about this in the PR, even suggesting this back then...

[ChrisDoernen]

Opened a PR: #301

@mstortz any suggestions?

[Arash-Sabet]

@ChrisDoernen I already merged the PR of #297 (comment) there other day and release 9.0.6 and since then @mstortz started experiencing the issue he described above. Unfortunately we started experiencing the same in another project and hence had to downgrade to the previous version.

I think, regardless I must deprecate 9.0.6 to release a newer version.

Can you explain how you are not experiencing the compile error that @mstortz experienced? What did you do after using 9.0.6 to prevent the issue?

[ChrisDoernen]

I am not experiencing the issue by migrating to xUnit 3 (xunit.v3 packages) in my solution. You can check this commit to see a working example in my repo. In particular see the changes in src/Directory.Packages.props.

Using xunit (version 2), I also experience the issues. So any release after the merge is not compatible with xUnit (version 2), and breaks code.

Bottom line for users: Use 9.0.5 and below with xUnit 2, use 9.0.6 and higher after migrating to xUnit 3.

As this is not obvious for users, it would be better to increment the major version for this breaking change and release a 10.0.0 for xUnit 3.

[Arash-Sabet]

Thanks @ChrisDoernen

I was thinking to use version 10.x.x pattern for this library when Microsoft releases .NET 10. While we are in the .NET 9.0 environment, what release number may be more suitable than what you suggested? Should we use 9.1.x moving forward until .NET 10 is rolled out?