Skip to content

Commit

Permalink
Fix for shellcheck, remove alex and misspel
Browse files Browse the repository at this point in the history
  • Loading branch information
gaurav-nelson committed May 14, 2024
1 parent 319ff1b commit 164eee8
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 27 deletions.
21 changes: 0 additions & 21 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,24 +37,3 @@ jobs:
with:
reporter: github-check
level: warning

misspell:
name: runner / misspell
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: reviewdog/action-misspell@v1
with:
reporter: github-check
level: warning
locale: "US"

alex:
name: runner / alex
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: reviewdog/action-alex@v1
with:
reporter: github-check
level: warning
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
github_token: ${{ secrets.github_token }}
reporter: github-pr-check
level: error
workdir: ./testdata/subdir/

test-pr-review:
if: github.event_name == 'pull_request'
Expand All @@ -44,7 +43,6 @@ jobs:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
level: error
filter_mode: file
fail_on_error: true
- name: check the exit code
if: ${{ !success() }}
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
### Flags for reviewdog ###
tool_name:
description: 'Tool name to use for reviewdog reporter.'
default: '<linter-name>'
default: 'Linkspector'
level:
description: 'Report level for reviewdog [info,warning,error].'
default: 'error'
Expand Down
4 changes: 2 additions & 2 deletions script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ echo '::endgroup::'

echo '::group:: Running linkspector with reviewdog 🐶 ...'
linkspector check -c "${INPUT_CONFIG_FILE}" -j |
reviewdog -efm="%f:%l:%c: %m" \
reviewdog -f=rdjson \
-name="${INPUT_TOOL_NAME}" \
-reporter="${INPUT_REPORTER}" \
-filter-mode="${INPUT_FILTER_MODE}" \
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
-level="${INPUT_LEVEL}" \
${INPUT_REVIEWDOG_FLAGS}
"${INPUT_REVIEWDOG_FLAGS}"
exit_code=$?
echo '::endgroup::'
exit $exit_code
4 changes: 3 additions & 1 deletion testdata/text.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
This is a test file.

It contains a broken link to [another file](testdata/does-not-exist.md).
It contains a broken link [to another file](testdata/does-not-exist.md).

Check failure on line 3 in testdata/text.md

View workflow job for this annotation

GitHub Actions / Linkspector

[linkspector] testdata/text.md#L3

Connot reach testdata/does-not-exist.md. Status: 404 Cannot find: testdata/does-not-exist.md
Raw output
message:"Connot reach testdata/does-not-exist.md. Status: 404 Cannot find: testdata/does-not-exist.md"  location:{path:"testdata/text.md"  range:{start:{line:3  column:27}  end:{line:3  column:72}}}  severity:ERROR  source:{name:"linkspector"  url:"https://github.com/UmbrellaDocs/linkspector"}

And a working hyperlink to [Google](https://www.google.com).

Updated markdown file.

0 comments on commit 164eee8

Please sign in to comment.