-
Notifications
You must be signed in to change notification settings - Fork 12
Hotfix add all locations to colorbar label #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix add all locations to colorbar label #295
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issue #294 by ensuring that the colorbar label placement accommodates all valid location combinations. Key changes include:
- Adding parameterized tests in ultraplot/tests/test_colorbar.py to verify label placement across various combinations.
- Refactoring the label placement logic in ultraplot/axes/base.py using helper functions for improved clarity and maintainability.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
ultraplot/tests/test_colorbar.py | Added new tests to cover diverse colorbar and label positions. |
ultraplot/axes/base.py | Refactored the colorbar label placement logic with helper functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests need work.
Addresses #294