Skip to content

Hotfix add all locations to colorbar label #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2025

Conversation

cvanelteren
Copy link
Contributor

Addresses #294

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

Attention: Patch coverage is 92.04545% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/axes/base.py 81.57% 3 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@cvanelteren cvanelteren requested a review from Copilot June 28, 2025 19:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #294 by ensuring that the colorbar label placement accommodates all valid location combinations. Key changes include:

  • Adding parameterized tests in ultraplot/tests/test_colorbar.py to verify label placement across various combinations.
  • Refactoring the label placement logic in ultraplot/axes/base.py using helper functions for improved clarity and maintainability.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ultraplot/tests/test_colorbar.py Added new tests to cover diverse colorbar and label positions.
ultraplot/axes/base.py Refactored the colorbar label placement logic with helper functions.

@cvanelteren cvanelteren added this to the v1.57.2 milestone Jun 28, 2025
@cvanelteren cvanelteren requested a review from beckermr June 28, 2025 20:28
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need work.

@beckermr beckermr merged commit 0f1febf into Ultraplot:main Jun 29, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants