Fix issue #49: Add null checks to prevent errors in domain mapping#51
Merged
superdav42 merged 1 commit intoUltimate-Multisite:mainfrom Jul 4, 2025
Merged
Conversation
… domain mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #49: Add null checks to prevent errors in domain mapping
Description
This PR addresses issue #49 where domain mapping is broken in 2.4.0-beta. The error occurs when trying to call
get_path()on a site object that doesn't exist, resulting in a fatal error:Changes Made
replace_urlmethod to verify that both the mapping and site objects exist before trying to use themmangle_urlmethod to prevent errors when the site doesn't existfix_srcsetmethod to ensure we have a valid mapping before processingBenefits
Testing
Fixes #49