Conversation
This is an update and collaboration to Ultimate Multisite, based on WP Ultimo, which was based on Pro Sites.
Changed all base images to reflect the new Ultimate Multisite name.
Simply added a white version of the logo to display on dark backgrounds. This was done quickly and needs to be re-done later.
Removed some embedded code for better and quicker integration. Also, preparing to add a few enhancements.
WalkthroughBumps plugin version to 2.4.8, updates repository references/badges to Multisite-Ultimate/ultimate-multisite, regenerates POT with updated source line references, and adds lazy loading of WP_Filesystem in Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller (code using files.php)
participant Files as inc/duplication/files.php
participant FS as WP_Filesystem (WP core)
Caller->>Files: call init_dir / rrmdir
Files->>Files: if !defined('WP_Filesystem')
alt WP_Filesystem not loaded
Files->>Files: include 'wp-admin/includes/file.php'
Files->>FS: WP_Filesystem() initialization
else WP_Filesystem already available
Note right of Files: proceed without include
end
Files->>FS: perform filesystem operations (mkdir/rmdir, etc.)
Files-->>Caller: return result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
readme.txt (2)
223-223: Update the repository URL to match the new branding.This line still references the old repository path
superdav42/wp-multisite-waas. Based on the updates elsewhere in this PR, it should be updated to the new repository path.Apply this diff:
-For support, please open an issue on the [GitHub repository](https://github.com/superdav42/wp-multisite-waas/issues). +For support, please open an issue on the [GitHub repository](https://github.com/Multisite-Ultimate/ultimate-multisite/issues).
336-336: Fix the incorrect repository URL.This URL references
superdav42/multisite-ultimatewhich appears to be incorrect. The repository name should beultimate-multisite(notmultisite-ultimate) based on the other updates in this PR.Apply this diff:
-For the complete changelog history, visit: https://github.com/superdav42/multisite-ultimate/releases +For the complete changelog history, visit: https://github.com/Multisite-Ultimate/ultimate-multisite/releaseslang/ultimate-multisite.pot (1)
5-5: POT header still reports version 2.4.7
Project-Id-Versionis stillUltimate Multisite 2.4.7, but the PR bumps the plugin to 2.4.8. Consider updating this header (or regenerating the POT viawp i18n make-pot) so translation tooling reflects the correct release.
🧹 Nitpick comments (1)
ultimate-multisite.php (1)
130-130: End-of-file comment is a minor style addition.This comment doesn't add functional value but is harmless. Consider whether this style is needed consistently across other PHP files in the project.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
README.md(9 hunks)inc/class-wp-ultimo.php(1 hunks)lang/ultimate-multisite.pot(5 hunks)readme.txt(1 hunks)ultimate-multisite.php(3 hunks)
🔇 Additional comments (6)
readme.txt (1)
8-8: LGTM - Version bump is correct.The stable tag has been updated to 2.4.8, which is consistent with the version updates in other files.
inc/class-wp-ultimo.php (1)
34-34: LGTM - Version constant updated correctly.The VERSION constant has been updated to '2.4.8', which is consistent with the version updates across the codebase.
ultimate-multisite.php (2)
7-7: LGTM - Version header updated correctly.The plugin version has been updated to 2.4.8, consistent with other files in this PR.
30-33: LGTM - Metadata updates are appropriate.The author list, package name, and version updates are consistent with the repository rebranding.
README.md (1)
4-4: LGTM - Repository URLs updated consistently.All repository references have been updated from
superdav42/wp-multisite-waastoMultisite-Ultimate/ultimate-multisite. The changes are comprehensive and consistent throughout the documentation.Also applies to: 16-16, 19-22, 54-54, 91-91, 103-103, 114-114, 194-194, 304-304, 310-310
lang/ultimate-multisite.pot (1)
12-12: Auto-generated POT timestamp and source references look fineThe updated
POT-Creation-Dateand the adjusted#: inc/list-tables/class-payment-list-table.php:…references are standard artifacts of regenerating the POT after PHP line shifts; no functional impact from these changes.Also applies to: 1420-1430, 16640-16650
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…isite into boofola
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
inc/duplication/files.php (1)
122-124: Overly permissive file permissions.Using
chmodwith0777grants read, write, and execute permissions to all users. This could allow unauthorized modification of upload directories.Consider using more restrictive permissions like
0755(owner rwx, group/others rx) or0775(owner/group rwx, others rx):-return $wp_filesystem->mkdir($path, 0777); +return $wp_filesystem->mkdir($path, 0755);-return $wp_filesystem->chmod($path, 0777, true); +return $wp_filesystem->chmod($path, 0755, true);
🧹 Nitpick comments (2)
inc/duplication/files.php (2)
115-127: Consider using the same WP_Filesystem check asrecurse_copy.The
recurse_copymethod (lines 71-74) checksif ( ! $wp_filesystem )which verifies the global is actually initialized, while this checksfunction_exists('WP_Filesystem'). The former is more robust because the function could exist but the global might not be initialized yet.For consistency, consider this pattern:
-if ( ! function_exists('WP_Filesystem')) { - require_once ABSPATH . 'wp-admin/includes/file.php'; -} /** @var $wp_filesystem WP_Filesystem_Base */ global $wp_filesystem; +if ( ! $wp_filesystem ) { + require_once ABSPATH . 'wp-admin/includes/file.php'; + WP_Filesystem(); +} -WP_Filesystem();This approach checks the actual initialization state rather than just function existence.
136-143: Same consistency suggestion asinit_dir.This has the same pattern inconsistency as
init_dir. Consider using therecurse_copyapproach that checks the global variable state:-if ( ! function_exists('WP_Filesystem')) { - require_once ABSPATH . 'wp-admin/includes/file.php'; -} /** @var $wp_filesystem WP_Filesystem_Base */ global $wp_filesystem; +if ( ! $wp_filesystem ) { + require_once ABSPATH . 'wp-admin/includes/file.php'; + WP_Filesystem(); +} -WP_Filesystem();
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
inc/duplication/files.php(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: PHP 8.4
- GitHub Check: cypress (8.1, chrome)
- GitHub Check: cypress (8.2, chrome)
🔇 Additional comments (1)
inc/duplication/files.php (1)
1-4: LGTM - Documentation improvement.The added header comment and PHPCS directive properly document the file and suppress a known filename convention warning.
2 participants
Summary by CodeRabbit
Chores
Documentation
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.