code changes for wp.org review #183
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| .invoice-box { | ||
| width: 100%; | ||
| margin: auto; | ||
| font-size: 16px; | ||
| line-height: 24px; | ||
| color: #555; | ||
| } | ||
|
|
||
| .invoice-box table { | ||
| width: 100%; | ||
| line-height: inherit; | ||
| text-align: left; | ||
| } | ||
|
|
||
| .invoice-box table td { | ||
| padding: 5px; | ||
| vertical-align: top; | ||
| } | ||
|
|
||
| .invoice-box table tr td:nth-child(2) { | ||
| text-align: right; | ||
| } | ||
|
|
||
| .invoice-box table tr.top table td { | ||
| padding-bottom: 20px; | ||
| } | ||
|
|
||
| .invoice-box table tr.top table td.title { | ||
| font-size: 45px; | ||
| line-height: 45px; | ||
| color: #333; | ||
| } | ||
|
|
||
| .invoice-box table tr.information table td { | ||
| padding-bottom: 40px; | ||
| } | ||
|
|
||
| .invoice-box table tr.heading td { | ||
| background: #eee; | ||
| border-bottom: 1px solid #ddd; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| .invoice-box table { | ||
| border-collapse: 1px; | ||
| } | ||
|
|
||
| .invoice-box table tr.heading th { | ||
| border-left: 1px solid #ddd; | ||
| border-right: 1px solid #ddd; | ||
| } | ||
|
|
||
| .invoice-box table tr.item td { | ||
| vertical-align: middle; | ||
| } | ||
|
|
||
| .invoice-box table tr.heading th { | ||
| background: #eee; | ||
| border-top: 1px solid #ddd; | ||
| border-bottom: 1px solid #ddd; | ||
| padding: 10px; | ||
| text-align: right; | ||
| font-weight: bold; | ||
| text-transform: uppercase; | ||
| font-size: 80%; | ||
| } | ||
|
|
||
| .invoice-box table tr.details td { | ||
| padding: 10px; | ||
| } | ||
|
|
||
| .invoice-box table tr.item td{ | ||
| border-bottom: 1px solid #eee; | ||
| padding: 10px; | ||
| } | ||
|
|
||
| .invoice-box table tr.item.last td { | ||
| border-bottom: none; | ||
| } | ||
|
|
||
| .invoice-box table tr.total td { | ||
| border-top: 2px solid #eee; | ||
| font-weight: bold; | ||
| padding-bottom: 60px; | ||
| padding-top: 10px; | ||
| text-align: right; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 600px) { | ||
| .invoice-box table tr.top table td { | ||
| width: 100%; | ||
| display: block; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .invoice-box table tr.information table td { | ||
| width: 100%; | ||
| display: block; | ||
| text-align: center; | ||
| } | ||
| } | ||
|
|
||
| /** RTL **/ | ||
| .rtl { | ||
| direction: rtl; | ||
|
|
||
| } | ||
|
|
||
| .rtl table { | ||
| text-align: right; | ||
| } | ||
|
|
||
| .rtl table tr td:nth-child(2) { | ||
| text-align: left; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -205,17 +205,6 @@ public function output_default_widget_customer_targets(): void { | |
|
|
||
| $customer_link = wu_network_admin_url('wp-ultimo-edit-customer', $url_atts); | ||
|
|
||
| $display_name = $customer->get_display_name(); | ||
|
|
||
| $id = $customer->get_id(); | ||
|
|
@@ -232,7 +221,16 @@ public function output_default_widget_customer_targets(): void { | |
| </a>', | ||
| esc_attr($customer_link), | ||
| esc_html($display_name), | ||
| get_avatar( | ||
| $customer->get_user_id(), | ||
| 32, | ||
| 'identicon', | ||
| '', | ||
| [ | ||
| 'force_display' => true, | ||
| 'class' => 'wu-rounded-full wu-border-solid wu-border-1 wu-border-white hover:wu-border-gray-400', | ||
| ] | ||
| ), | ||
| esc_html($id), | ||
| esc_html($email) | ||
| ); | ||
|
|
@@ -245,16 +243,6 @@ public function output_default_widget_customer_targets(): void { | |
|
|
||
| $email = $customer->get_email_address(); | ||
|
|
||
| $url_atts = [ | ||
| 'id' => $customer->get_id(), | ||
| ]; | ||
|
|
@@ -265,7 +253,15 @@ public function output_default_widget_customer_targets(): void { | |
| "<div class='wu-flex wu--mr-4'><a role='tooltip' aria-label='%s' href='%s'>%s</a></div>", | ||
| esc_attr($tooltip_name), | ||
| esc_attr($customer_link), | ||
| get_avatar( | ||
| $email, | ||
| 32, | ||
| 'identicon', | ||
| '', | ||
| [ | ||
| 'class' => 'wu-rounded-full wu-border-solid wu-border-1 wu-border-white hover:wu-border-gray-400', | ||
| ] | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
|
|
@@ -459,6 +455,7 @@ public function query_filter($args) { | |
| */ | ||
| public function get_object() { | ||
|
|
||
| // Data is only being fetch, nothing is being modified, no need for nonce check. | ||
| if (isset($_GET['id'])) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended | ||
| $query = new \WP_Ultimo\Database\Broadcasts\Broadcast_Query(); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,7 +91,7 @@ public function init(): void { | |
|
|
||
| parent::init(); | ||
|
|
||
| $this->generate_checkout_form_preview(); | ||
|
|
||
| add_action('wp_ajax_wu_save_editor_session', [$this, 'save_editor_session']); | ||
|
|
||
|
|
@@ -171,8 +171,6 @@ public function content_checkout_form_by_settings(): void { | |
| return; | ||
| } | ||
|
|
||
| $key = wp_get_session_token(); | ||
|
|
||
| $session = \WP_Session_Tokens::get_instance(get_current_user_id()); | ||
|
|
@@ -193,12 +191,20 @@ public function content_checkout_form_by_settings(): void { | |
| $current_user = wp_set_current_user(0); | ||
| } | ||
|
|
||
| wp_enqueue_scripts(); | ||
|
|
||
| wp_print_head_scripts(); | ||
|
|
||
| printf('<body %s>', 'class="' . esc_attr(implode(' ', get_body_class('wu-styling'))) . '"'); | ||
|
|
||
| echo '<div class="wu-p-6">'; | ||
|
|
||
| $count = count($settings); | ||
|
|
||
| foreach ($settings as $index => $step) { | ||
| $final_fields = wu_create_checkout_fields($step['fields']); | ||
|
|
||
| wu_get_template( | ||
| 'checkout/form', | ||
| [ | ||
| 'step' => $step, | ||
|
|
@@ -212,20 +218,10 @@ public function content_checkout_form_by_settings(): void { | |
| ); | ||
|
|
||
| if ($index < $count - 1) { | ||
| printf('<hr class="sm:wu-bg-transparent wu-hr-text wu-font-semibold wu-my-4 wu-mt-6 wu-text-gray-600 wu-text-sm" data-content="%s">', esc_attr__('Step Separator', 'multisite-ultimate')); | ||
| } | ||
| } | ||
|
|
||
| wp_print_footer_scripts(); | ||
|
|
||
| echo '</div></body>'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -997,9 +997,9 @@ public function render_country() { | |||||||||||||||||
|
|
||||||||||||||||||
| if ($country_code) { | ||||||||||||||||||
| $html = sprintf( | ||||||||||||||||||
| '<span>%s</span><span class="wu-flag-icon wu-w-5 wu-ml-1" role="tooltip" aria-label="%s">%s</span>', | ||||||||||||||||||
| $country_name, | ||||||||||||||||||
| esc_attr($country_name), | ||||||||||||||||||
| wu_get_flag_emoji((string) $country_code) | ||||||||||||||||||
|
Comment on lines
+1000
to
1003
Contributor
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainFix ARIA misuse and escape output in render_country(). role="tooltip" on a static span is incorrect and causes duplicate announcements; the flag is decorative because the country name is already printed. Also escape outputs per WP standards. - '<span>%s</span><span class="wu-flag-icon wu-w-5 wu-ml-1" role="tooltip" aria-label="%s">%s</span>',
- $country_name,
- esc_attr($country_name),
- wu_get_flag_emoji((string) $country_code)
+ '<span>%s</span><span class="wu-flag-icon wu-w-5 wu-ml-1" aria-hidden="true">%s</span>',
+ esc_html($country_name),
+ esc_html(wu_get_flag_emoji((string) $country_code))Optional (if you truly need a tooltip later): use a trigger with aria-describedby pointing to a hidden tooltip element, not role="tooltip" on the icon itself. To check for similar cases: 🏁 Script executed: #!/bin/bash
rg -nP -C2 'role\s*=\s*"tooltip"' --type=phpLength of output: 8035 Fix ARIA misuse and escape outputs across the codebase role="tooltip" is applied to static/decorative elements (causes duplicate screen-reader announcements). Replace decorative icons with aria-hidden="true", escape outputs with esc_html/esc_attr, and implement real tooltips using a trigger + aria-describedby when required. Prefer fixing the helper(s) in inc/functions/markup-helpers.php to avoid repetition. Occurrences to update (from your search):
Apply the local fix (example) for inc/admin-pages/class-customer-edit-admin-page.php: - '<span>%s</span><span class="wu-flag-icon wu-w-5 wu-ml-1" role="tooltip" aria-label="%s">%s</span>',
- $country_name,
- esc_attr($country_name),
- wu_get_flag_emoji((string) $country_code)
+ '<span>%s</span><span class="wu-flag-icon wu-w-5 wu-ml-1" aria-hidden="true">%s</span>',
+ esc_html($country_name),
+ esc_html(wu_get_flag_emoji((string) $country_code))Confirm before committing with: 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| ); | ||||||||||||||||||
| } else { | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -608,20 +608,16 @@ public function render_csv_button($args): void { | |
|
|
||
| $data_strings = wp_json_encode($args['data']); | ||
|
|
||
| printf( | ||
| '<div class="wu-bg-gray-100 wu-p-2 wu-text-right wu-border-0 wu-border-b wu-border-solid wu-border-gray-400"> | ||
| <a href="#" attr-slug-csv="%2$s" class="wu-export-button wu-no-underline wu-text-gray-800 wu-text-xs"> | ||
| <span class="dashicons-wu-download wu-mr-1"></span> %1$s | ||
| </a> | ||
| <input type="hidden" id="csv_headers_%2$s" value="%3$s" /> | ||
| <input type="hidden" id="csv_data_%2$s" value="%4$s" /> | ||
| <input type="hidden" id="csv_action_%2$s" value="%5$s" /> | ||
| </div>', | ||
| esc_html__('CSV', 'multisite-ultimate'), | ||
| esc_attr($slug), | ||
|
Comment on lines
+611
to
621
Contributor
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainUse data- attributes and keep label filter for backward compatibility.* Custom attributes should be data-* per HTML5. Also, hard-coding the label drops the prior customization point. Apply this diff: - printf(
- '<div class="wu-bg-gray-100 wu-p-2 wu-text-right wu-border-0 wu-border-b wu-border-solid wu-border-gray-400">
- <a href="#" attr-slug-csv="%2$s" class="wu-export-button wu-no-underline wu-text-gray-800 wu-text-xs">
- <span class="dashicons-wu-download wu-mr-1"></span> %1$s
+ printf(
+ '<div class="wu-bg-gray-100 wu-p-2 wu-text-right wu-border-0 wu-border-b wu-border-solid wu-border-gray-400">
+ <a href="#" data-slug-csv="%2$s" class="wu-export-button wu-no-underline wu-text-gray-800 wu-text-xs">
+ <span class="dashicons-wu-download wu-mr-1"></span> %1$s
</a>
<input type="hidden" id="csv_headers_%2$s" value="%3$s" />
<input type="hidden" id="csv_data_%2$s" value="%4$s" />
<input type="hidden" id="csv_action_%2$s" value="%5$s" />
</div>',
- esc_html__('CSV', 'multisite-ultimate'),
+ esc_html(apply_filters('wu_export_data_table_label', __('CSV', 'multisite-ultimate'))),
esc_attr($slug),
esc_attr($header_strings),
esc_attr($data_strings),
esc_attr($args['action'])
);If JS reads the old attribute, update it: 🏁 Script executed: #!/bin/bash
# Update JS to read data-slug-csv instead of attr-slug-csv
rg -n 'attr-slug-csv'Length of output: 4278 Use HTML5 data-attributes and enable CSV label filtering
🤖 Prompt for AI Agents |
||
| esc_attr($header_strings), | ||
| esc_attr($data_strings), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -401,8 +401,8 @@ protected function add_list_table_widget($id, $atts = []) { | |
| $atts, | ||
| [ | ||
| 'widget_id' => $id, | ||
| 'before' => fn() => null, | ||
| 'after' => fn() => null, | ||
| 'title' => __('List Table', 'multisite-ultimate'), | ||
|
Comment on lines
+404
to
406
Contributor
There was a problem hiding this comment. Potential fatal: defaulting 'before'/'after' to Closures may break templates expecting strings. If widget-list-table template echoes these keys, echoing a Closure triggers “Object of class Closure could not be converted to string.” Either revert defaults to strings, or ensure templates treat them as callable-or-string. Minimal safe fix (consistent with other methods in this class): - 'before' => fn() => null,
- 'after' => fn() => null,
+ 'before' => '',
+ 'after' => '',Alternatively, normalize just before rendering: $before = $atts['before'];
$after = $atts['after'];
$render = static fn($seg) => is_callable($seg) ? $seg() : print $seg;
...
// in the meta box callback, use $render($before); ... $render($after);🤖 Prompt for AI Agents |
||
| 'position' => 'advanced', | ||
| 'screen' => get_current_screen(), | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid value for border-collapse; browsers will ignore this.
border-collapse: 1px;is not valid CSS. Usecollapse(and addborder-spacing: 0;for completeness). Otherwise you’ll get separated borders and inconsistent rendering across HTML-to-PDF engines.Apply this diff:
.invoice-box table { - border-collapse: 1px; + border-collapse: collapse; + border-spacing: 0; }📝 Committable suggestion
🤖 Prompt for AI Agents