Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-12309 hard crash when modifying a post processing setting value with auto slice #991

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Mar 14, 2025

This could happen when an other Cura window was open, apparently the QML rendering then creates a different OpenGL context and we need to switch back to our own context before starting to draw

CURA-12309
Fixes Ultimaker/Cura#19904

CURA-12309
This could happen when an other Cura window was open, apparently the QML rendering then creates a different OpenGL context and we need to switch back to our own context before starting to draw
Copy link

github-actions bot commented Mar 14, 2025

Test Results

2 407 tests  ±0   2 391 ✅  - 1   22s ⏱️ ±0s
    1 suites ±0      15 💤 ±0 
    1 files   ±0       1 ❌ +1 

For more details on these failures, see this check.

Results for commit 3fe12a0. ± Comparison against base commit 398ec53.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HellAholic HellAholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more crashing

@HellAholic HellAholic merged commit 3ff653d into 5.10 Mar 17, 2025
5 of 8 checks passed
@HellAholic HellAholic deleted the CURA-12309_hard-crash-when-modifying-a-post-processing-setting-value-with-auto-slice branch March 17, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants