Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURA-12403 Fix wrongly switching project name #989

Merged
merged 2 commits into from
Mar 14, 2025
Merged

CURA-12403 Fix wrongly switching project name #989

merged 2 commits into from
Mar 14, 2025

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Mar 12, 2025 •
edited
Loading

CURA-12403

⚠️ This is technically an API change, but we already made the annoucement for the API change. Should we still update the wiki silently ?

Comes with Ultimaker/Cura#20377

@wawanbreton wawanbreton changed the base branch from main to 5.10 March 12, 2025 11:05
@wawanbreton wawanbreton mentioned this pull request Mar 12, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2025 •
edited
Loading

Test Results

2 407 tests  ±0   2 392 ✅ ±0   23s ⏱️ -1s
    1 suites ±0      15 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit add9a2f. ± Comparison against base commit 2656e61.

♻️ This comment has been updated with latest results.

@rburema
Copy link
Member

rburema commented Mar 13, 2025

Technically it's even a major change :-p

What I'd do is keep the old method, mark it as deprecated, and don't use it ourselves. Then we can remove it in the next major.

rburema
rburema requested changes Mar 13, 2025
View reviewed changes
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can re-add the (deprecated) project myself as well, then after I'm done testing, send it to QA?

@wawanbreton
Copy link
Contributor Author

I can re-add the (deprecated) project myself as well, then after I'm done testing, send it to QA?

That would make sense, yes please

@rburema
Reintroduce getLastOutputName as deprecated, otherwise we'd need a ma…
add9a2f 
…jor SDK increase.

done as part of CURA-12403
@HellAholic HellAholic merged commit 2ce596e into 5.10 Mar 14, 2025
8 checks passed
@HellAholic HellAholic deleted the CURA-12403_project-names-revert-to-previous-name branch March 14, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rburema rburema rburema requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wawanbreton @rburema @HellAholic