CURA-12400 improve open source referencing #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12400 Some of the dependencies we use are not directly accessible via pip or conan, so add a field for manually registered dependencies
rburema
reviewed
Feb 19, 2025
Comment on lines
+9
to
+10
| sources_url: https://code.qt.io/cgit/qt/qtbase.git | ||
| home_url: https://github.com/Ultimaker/Cura/blob/main/licenses_thirdparty/qt.md |
There was a problem hiding this comment.
I'm not sure you changed the right one here? Do we still want to link to the original qtbase repo in the sources_url?
rburema
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Qt as an extra dependency for which we want to display the license
CURA-12400
Requires Ultimaker/Cura#20291