Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene.py add _hideReloadMessage, connect to startReloadAll #964

Open
wants to merge 1 commit into
base: 5.8
Choose a base branch
from

Conversation

dfries
Copy link

@dfries dfries commented Sep 3, 2024

When all files are being reloaded, the file modification reload dialog is redundant. This allows pressing F5 to reload and dismiss the dialog.

Description

This commit depends on the Cura commit "Add startReloadAll signal when reloadAll is called" in pull request Ultimaker/Cura#19608, which adds the signal startReloadAll. This Uranium change will connect to the signal to cancel file modification reload dialog. Once all the models
are reloaded, the file modification reload dialog is not needed.

Type of change

  • New feature (non-breaking change which adds functionality) I could argue this is a bug.

How Has This Been Tested?

  • Exercise F5 reloadAll
  1. Load a set of models
  2. Externally modify a file
  3. Verify "File has been modified" dialog shows, don't click it
  4. Press F5, verify the new model shows and "File has been modified" dialog hides

Test Configuration:

  • Operating System: Debian Linux

Checklist:

When all files are being reloaded, the file modification reload
dialog is redundant.  This allows pressing F5 to reload and dismiss
the dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant