CURA-13226 Engine adjustments for benchmark tooling#2345
Open
Erwan MATHIEU (wawanbreton) wants to merge 15 commits into
Open
CURA-13226 Engine adjustments for benchmark tooling#2345Erwan MATHIEU (wawanbreton) wants to merge 15 commits into
Erwan MATHIEU (wawanbreton) wants to merge 15 commits into
Conversation
CURA-13226 Now that the GCode resolving is fully done at the end of the processing, we can generate the full header regardless of the communication method. Thus the isSequential() and the sendGCodeprefix() are no more required. The header is not sent as a regular piece of GCode using sendGCodePart().
Contributor
Test Results31 tests 31 ✅ 4s ⏱️ Results for commit 50e76d7. ♻️ This comment has been updated with latest results. |
Contributor
Author
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 0b3f822 | Previous: 4d5fb16 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_local |
8.381421742923362 ns/iter |
1.2540880137436994 ns/iter |
6.68 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: Jelle Spijker (@jellespijker) Erwan MATHIEU (@wawanbreton) Casper Lamboo (@casperlamboo) HellAholic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides two minor improvements that were necessary for the new benchmarking tools:
Communicationobjects don't need theisSequentialmethod anymore, and they will all get the very same GCode header. The header is also now sent as a regular GCode part, so we don't need the specificGCodePrefixmessage.CURA-13226