Add engine info handler for getting engine version and hash #2146
Conversation
Implemented a handler for the `--engine_info_cb` flag to handle engine information retrieval. Added functionality to create and send engine info messages, which include the Cura engine version and hash, to Emscripten. Updated CMake and conan files to pass Cura engine hash. NP-349
Introduced a new function `beginGCode` to indicate the start of g-code sending with curaengine info. NP-349
Include a 'commit' field in conandata.yml to store the commit hash. NP-349
NP-349
There was a problem hiding this comment.
LGTM;
But you might want to base it and merge it to 5.9 instead of main also ask @wawanbreton or @rburema for a review
|
Do you need this in 5.9 ? If not, it is preferable to keep it in main. |
Neoprep will be based on 5.9, so yes we need it in the release branch. @saumyaj3 needs to base it from I don't think there will be any risk for Cura with merging it since the changes are in the Emscripten communication class, which will not be compiled for desktop applications |
|
I changed it to 5.9 branch |
|
@saumya did you also base it from 5.9? otherwise we will pull in main into 5.9 |
|
I started working from main. The package created is also from main. I can also recreate the packages |
Implemented a handler for the
--engine_info_cbflag to handle engine information retrieval. Added functionality to create and send engine info messages, which include the Cura engine version and hash, to Emscripten. Updated CMake and conan files to pass Cura engine hash.NP-349