Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'fdmprinter.def.json' #20172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GregValiant
Copy link
Collaborator

This will be a draft. The changes to the tooltips should be OK, but the others I'm not 100% sure on.

Alter two settings:
'material_initial_print_temperature' and 'material_final_print_temperature'
Change the tooltips to better describe the settings (the current wording is not clear), and change the "enabled" logic to include " and machine_extruder_count > 1". (That will need to be checked but it doesn't appear that the settings are used for single extruder prints.)
Tooltip changes will of course require translation changes.
Changed the "type" from float to int as most machines aren't really set up for 1/100 of a degree.
Changed the minimum_value from "-273.15" to "0" because it was just silly.
Changed the maximum_value
Changed the default value from 200 to material_print_temperature

This fixes... OR This improves... -->

This is in response to a couple of bug reports including #20168 and #19190 and maybe #14019

Type of change

  • [ X] Improvement / clarification

How Has This Been Tested?

I have had both settings hidden for years.

Test Configuration:

  • Operating System:
    Win10Pro and Cura versions since 4.8 (although the settings were disabled using definition file overrides).

Checklist:

  • [X ] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ not applicable ] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

Alter two settings:
'material_initial_print_temperature' and 'material_final_print_temperature'
Change the tooltips and change the "enabled" logic to include
" and machine_extruder_count > 1"
@GregValiant GregValiant marked this pull request as draft January 23, 2025 01:52
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Test Results

23 370 tests  ±0   23 364 ✅  - 4   45s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        4 ❌ +4 

For more details on these failures, see this check.

Results for commit 308aeab. ± Comparison against base commit 3095acd.

♻️ This comment has been updated with latest results.

@HellAholic
Copy link
Contributor

HellAholic commented Jan 23, 2025

Tooltip change and number of extruders check is good. The setting is for multi-extruder printers mainly for when a switch happens.

I would not change the other settings as there could be side effects.
So I've heard so many stories about people printing all kinds of stuff on FDM printers, ranging from metal to chocolate to ceramics to ice-cream [Why are you against ice-cream printers :)] So while the range for average user might not be useful, it allows for creativity and experimentation. Same with the float vs int.
That's just my personal 2 cents about this.

Set the type, max values and min values back to previous.
@GregValiant GregValiant marked this pull request as ready for review January 23, 2025 20:41
@GregValiant
Copy link
Collaborator Author

GregValiant commented Jan 23, 2025

Hah! Gotcha.
Even ice dream won't print at absolute zero.

I reverted everything except for the tooltips and the "enabled" logic.

@HellAholic
Copy link
Contributor

HellAholic commented Jan 23, 2025

Around -190 is the sweet spot xD with liquid nitrogen but I think the original implementation was like: "If you wanna do something wrong, do it right" and went for the easy sure way. (these are just speculations, any similarities between this and any character, real or fictional is completely accidental).

@GregValiant
Copy link
Collaborator Author

Way off topic, I bought a "Chocolate" extruder system. It worked OK except that the build plate needed that liquid nitrogen system. Everything just turned onto a blob of chocolate. Mind you, I'm not saying I didn't eat the scrap, but the prints didn't turn out at all. The entire gizmo has been sitting on a shelf for 2 years.

I was going to add a "cold air duct" to the layer cooling fan. Probably draw the air across a bucket of ice before blowing it on the print. I gave up when I tried to design the duct as it would constantly be moving with the X axis and moving up in the Z.

The rest of the chocolate was good though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants