Update DisplayProgressOnLCD.py #11846
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Layer advance (new "Layer Left" BTREE functionality) when printing from Octoprint.
|
Note: I've not tested this plugin with modified BTREE firmware because it's not yet available. New messages are properly created but not merge until functionality is fully tested. |
|
@inigoml I think a minor fix will be done for layer 0, it return this for first layer in gcode: ;LAYER:0 Layer 0 must be return M118 A1 P0 action:notification Layer Left 1/191 Current layer must have +1 in result. |
You are right. Done and committed. |
|
Hey @inigoml has the BTREE firmware been released yet? If so have you managed to test it? |
Joeydelarago
added
the
Status: Needs Info
|
Hey @inigoml, I've converted this to a draft PR for now. Please click ready for review after this is tested. Thanks 👍 |
Merged
nallath
added
the
PR: Post Processing ➕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Layer advance (new "Layer Left" BTREE functionality) when printing from Octoprint.