Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
  • Loading branch information
jellespijker and casperlamboo authored Dec 8, 2023
1 parent 065f22b commit f2f2f74
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 35 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/conan-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,15 @@ env:
CONAN_LOGIN_USERNAME_CURA: ${{ secrets.CONAN_USER }}
CONAN_PASSWORD_CURA: ${{ secrets.CONAN_PASS }}

# FIXME: point to `main` once merged
jobs:
conan-recipe-version:
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@main
with:
project_name: cura

conan-package-export:
needs: [ conan-recipe-version ]
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-export.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-export.yml@main
with:
recipe_id_full: ${{ needs.conan-recipe-version.outputs.recipe_id_full }}
recipe_id_latest: ${{ needs.conan-recipe-version.outputs.recipe_id_latest }}
Expand Down
14 changes: 5 additions & 9 deletions .github/workflows/installers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,15 @@ env:

jobs:
default_values:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-default-value.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-default-value.yml@main
with:
cura_conan_version: ${{ inputs.cura_conan_version }}
latest_release: '5.6'
latest_release_schedule_hour: 4
latest_release_tag: 'nightly'

# FIXME: point to `main` once merged
windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@main
needs: [ default_values ]
with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
Expand All @@ -62,9 +61,8 @@ jobs:
operating_system: windows-2022
secrets: inherit

# FIXME: point to `main` once merged
linux-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@main
needs: [ default_values ]
with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
Expand All @@ -75,9 +73,8 @@ jobs:
operating_system: ubuntu-22.04
secrets: inherit

# FIXME: point to `main` once merged
macos-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@main
needs: [ default_values ]
with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
Expand All @@ -88,9 +85,8 @@ jobs:
operating_system: self-hosted-X64
secrets: inherit

# FIXME: point to `main` once merged
macos-arm-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@main
needs: [ default_values ]
with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ env:
STAGING: ${{ inputs.staging || false }}

jobs:
# FIXME: point to `main` once merged
windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@main
with:
cura_conan_version: ${{ inputs.cura_conan_version }}
conan_args: ${{ inputs.conan_args }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@ env:
STAGING: ${{ inputs.staging || false }}

jobs:
# FIXME: point to `main` once merged
windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@main
with:
cura_conan_version: ${{ inputs.cura_conan_version }}
conan_args: ${{ inputs.conan_args }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/process-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ on:
pull_request_target:
types: [ opened, reopened, edited, review_requested, ready_for_review, assigned ]

# FIXME: Use `main` instead of `CURA-10831` once merged
jobs:
add_label:
uses: ultimaker/cura-workflows/.github/workflows/process-pull-request.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/process-pull-request.yml@main
secrets: inherit
3 changes: 1 addition & 2 deletions .github/workflows/unit-test-post.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ on:
types: [ completed ]

jobs:
# FIXME: Use `main` instead of `CURA-10831` once merged
publish-test-results:
uses: ultimaker/cura-workflows/.github/workflows/unit-test-post.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/unit-test-post.yml@main
with:
event: ${{ github.event.workflow_run.event }}
conclusion: ${{ github.event.workflow_run.conclusion }}
6 changes: 2 additions & 4 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,13 @@ env:
CONAN_PASSWORD: ${{ secrets.CONAN_PASS }}

jobs:
# FIXME: Change to `main` instead of `CURA-10831` once merged
conan-recipe-version:
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@main
with:
project_name: cura

testing:
# FIXME: Change to `main` instead of `CURA-10831` once merged
uses: ultimaker/cura-workflows/.github/workflows/unit-test.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/unit-test.yml@main
needs: [ conan-recipe-version ]
with:
recipe_id_full: ${{ needs.conan-recipe-version.outputs.recipe_id_full }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ env:
STAGING: ${{ inputs.staging || false }}

jobs:
# FIXME: point to `main` once merged
windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@CURA-10831
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@main
with:
cura_conan_version: ${{ inputs.cura_conan_version }}
conan_args: ${{ inputs.conan_args }}
Expand Down
18 changes: 9 additions & 9 deletions conandata.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
version: "5.7.0-alpha.0"
requirements:
- "uranium/(latest)@ultimaker/cura_10831"
- "curaengine/(latest)@ultimaker/cura_10831"
- "cura_binary_data/(latest)@ultimaker/cura_10831"
- "fdm_materials/(latest)@ultimaker/cura_10831"
- "curaengine_plugin_gradual_flow/(latest)@ultimaker/cura_10831"
- "dulcificum/(latest)@ultimaker/cura_10831"
- "uranium/(latest)@ultimaker/latest"
- "curaengine/(latest)@ultimaker/latest"
- "cura_binary_data/(latest)@ultimaker/latest"
- "fdm_materials/(latest)@ultimaker/latest"
- "curaengine_plugin_gradual_flow/(latest)@ultimaker/stable"
- "dulcificum/(latest)@ultimaker/latest"
- "pyarcus/5.3.0"
- "pysavitar/5.3.0"
- "pynest2d/5.3.0"
- "curaengine_grpc_definitions/(latest)@ultimaker/cura_10831"
- "curaengine_grpc_definitions/(latest)@ultimaker/latest"
requirements_internal:
- "fdm_materials/(latest)@internal/cura_10831"
- "cura_private_data/(latest)@internal/cura_10831"
- "fdm_materials/(latest)@internal/latest"
- "cura_private_data/(latest)@internal/latest"
urls:
default:
cloud_api_root: "https://api.ultimaker.com"
Expand Down

0 comments on commit f2f2f74

Please sign in to comment.