fix: properly handle error types in context manager#79
Merged
andreitava-uip merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
radu-mocanu
reviewed
Feb 10, 2026
Collaborator
radu-mocanu
left a comment
radu-mocanu
left a comment
There was a problem hiding this comment.
can t we just match by exc_val insead?
Contributor
Author
that would also work. |
andreitava-uip
force-pushed
the
fix/context-error-handling
branch
from
d2e8c4c to
2bbf6ff
Compare
radu-mocanu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code matched a type against instances. so all exceptions got into the Generic error fallback.
The fix does two things:
exc_valinsteadUiPathRuntimeErrorwithUiPathBaseRuntimeError, to handle more cases