Revamp CoreIpc [ROBO-3791] #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduard-dumitru
force-pushed
the
feat/revamp_lean
branch
2 times, most recently
from
84bb59a to
ad64ac2
Compare
--------
1. Pipelines
- (TBR) disable the constraint of pushing NuGet packages to the feed
only when source branch is master
- (TBD) restore, build and pack the main solution explicitly
before running unit tests
- Use .NET Runtime 8.0.8 and UseDotNet@2 for both 6.0.317 and 8.0.400
2. General
- change the UiPath.CoreIpc* namespace to UiPath.Ipc*
- decomission the usage of Nito
- start optimizing logging via LoggerMessageAttribute
3. API and behavior
- commission the new Ipc API that doesn't rely on the fluent builder pattern
- commission the feature that allows the optional BeforeCall
of an IpcServer Endpoint to share its AsyncLocal context
with the target method execution, if the BeforeCall executes
synchronously.
Check the ServerBeforeCall_WhenSync_ShouldShareAsyncLocalContextWithTheTargetMethodCall test for further details.
- extensibility support for potentially any transport, including JS-DotNetWasm interop
4. Internals
- decommission the generic variant of ServiceClient, thus greatly simplifying the flow
- commission the ServiceClientProper and ServiceClientForCallback subclasses
eduard-dumitru
force-pushed
the
feat/revamp_lean
branch
from
ad64ac2 to
6b263e6
Compare
- simplifications
- decommission WaitForStop
- decommission the duplication of IClient methods in Message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Pipelines
only when the source branch is
masterbefore running unit tests
General
API and behavior
of an IpcServer Endpoint to share its AsyncLocal context
with the target method execution, if the BeforeCall executes
synchronously.
Check the ServerBeforeCall_WhenSync_ShouldShareAsyncLocalContextWithTheTargetMethodCall test for further details.
Internals