Skip to content

fix(apollo-react): handles in flow [MST-6514] #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayush578 merged 1 commit into from
Feb 19, 2026
Merged

fix(apollo-react): handles in flow [MST-6514] #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/apollo-react/src/canvas/components/ButtonHandle/ButtonHandle.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,24 @@ export const StyledLine = styled.div<{ $isVertical: boolean; $selected: boolean;
transition: border-color 0.2s ease-in-out;
`;

export const StyledLabel = styled.div<{ $position: Position; $backgroundColor: string }>`
export const StyledLabel = styled.div<{
$position: Position;
$backgroundColor: string;
$shouldTruncate?: boolean;
}>`
position: absolute;
background-color: ${(p) => p.$backgroundColor};
padding: 2px 6px;
border-radius: 4px;
z-index: 1;
white-space: nowrap;
user-select: none;
${(p) =>
p.$shouldTruncate &&
css`
max-width: 50px;
overflow: hidden;
`}

${(p) =>
p.$position === Position.Top &&
Expand Down
19 changes: 18 additions & 1 deletion packages/apollo-react/src/canvas/components/ButtonHandle/ButtonHandle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ const ButtonHandleBase = ({
const markAsHovered = useCallback(() => setIsHovered(true), []);
const unmarkAsHovered = useCallback(() => setIsHovered(false), []);

const shouldTruncateLabel = useMemo(() => {
return showButton && !!onAction && type === 'source' && !isVertical;
}, [showButton, onAction, type, isVertical]);

return (
<StyledHandle
type={type}
Expand All @@ -162,12 +166,25 @@ const ButtonHandleBase = ({
onMouseDown={unmarkAsHovered}
>
{label && (
<StyledLabel $position={position} $backgroundColor={labelBackgroundColor}>
<StyledLabel
$position={position}
$backgroundColor={labelBackgroundColor}
$shouldTruncate={shouldTruncateLabel}
>
<Row align="center" gap={4}>
{labelIcon}
<ApTypography
color="var(--uix-canvas-foreground-de-emp)"
variant={FontVariantToken.fontSizeSBold}
sx={
shouldTruncateLabel
? {
overflow: 'hidden',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
}
: undefined
}
>
{label}
</ApTypography>
Expand Down
Loading