Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database: Upgrade dependency packages (24.11) [STUD-69625] #433

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

viogroza
Copy link
Collaborator

@viogroza viogroza commented Jul 16, 2024

Upgrade Microsoft.Data.SqlClient to 5.2.1
Upgrade Oracle.ManagedDataAccess to 19.22.0
Upgrade Oracle.ManagedDataAccess.Core to 23.5.0
Fix custom providers for legacy
Upgrade Microsoft.Data.SqlClient.SNI.dll and Microsoft.Data.SqlClient.SNI.x86.dll

I upgraded only the above packages to the latest version that was still compatible with Net461 (where applicable)

https://uipath.atlassian.net/browse/STUD-69625

<PackageReference Include="System.Resources.Extensions" Version="5.0.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0-windows' or '$(TargetFramework)' == 'net6.0'">
<PackageReference Include="System.Data.Odbc" Version="7.0.0" />
<PackageReference Include="System.Data.OleDb" Version="7.0.0" />
<PackageReference Include="UiPath.Workflow" />
<PackageReference Include="Oracle.ManagedDataAccess.Core" Version="3.21.90" PrivateAssets="All" />
<PackageReference Include="Oracle.ManagedDataAccess.Core" Version="23.5.0" PrivateAssets="All" />
Copy link
Collaborator

@sorinconstantin sorinconstantin Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that's a huge leap forward 🚀
I hope it doesn't add any breaking changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they changed the versioning system.. it jumps from 3.xx to 23.xx
https://www.nuget.org/packages/Oracle.ManagedDataAccess.Core/#versions-body-tab

Upgrade Microsoft.Data.SqlClient to 5.2.1
Upgrade Oracle.ManagedDataAccess to 19.22.0
Upgrade Oracle.ManagedDataAccess.Core to 23.5.0
Fix custom providers for legacy
Upgrade Microsoft.Data.SqlClient.SNI.dll and Microsoft.Data.SqlClient.SNI.x86.dll
@viogroza viogroza force-pushed the fix/database_upgrade_to_5_2_0 branch from 2abde03 to 26bdb92 Compare July 17, 2024 13:09
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@@ -11,7 +11,7 @@
<PackageReference Include="System.Activities" />
<PackageReference Include="UiPath.Workflow" />
<PackageReference Include="System.Activities.Core.Presentation" />
<PackageReference Include="Oracle.ManagedDataAccess.Core" Version="3.21.90" PrivateAssets="All" />
<PackageReference Include="Oracle.ManagedDataAccess.Core" Version="23.5.0" PrivateAssets="All" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: TAB / space misalignment

@alexandru-petre alexandru-petre merged commit 4818fc6 into develop Jul 17, 2024
2 of 3 checks passed
@alexandru-petre alexandru-petre deleted the fix/database_upgrade_to_5_2_0 branch July 17, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants