FileService: a way to work with file at frontend #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catap
force-pushed
the
save-bytes-as-file
branch
from
e92d4bc to
f3ac0f6
Compare
catap
changed the title
ddworak
requested changes
Sep 22, 2020
catap
force-pushed
the
save-bytes-as-file
branch
from
f3ac0f6 to
762c992
Compare
|
@ddworak I have no idea when to revoke this URL. If you have some, feel free to share. |
catap
force-pushed
the
save-bytes-as-file
branch
6 times, most recently
from
9a7f575 to
93b95be
Compare
catap
force-pushed
the
save-bytes-as-file
branch
2 times, most recently
from
e223de8 to
414b03f
Compare
catap
force-pushed
the
save-bytes-as-file
branch
from
414b03f to
53a6021
Compare
ddworak
requested changes
Dec 1, 2020
guide/guide/.js/src/main/scala/io/udash/web/guide/views/frontend/demos/FileInputDemo.scala
Show resolved
Hide resolved
guide/guide/.js/src/main/scala/io/udash/web/guide/views/frontend/demos/FileInputDemo.scala
Outdated
Show resolved
Hide resolved
guide/guide/.js/src/main/scala/io/udash/web/guide/views/frontend/demos/FileInputDemo.scala
Outdated
Show resolved
Hide resolved
catap
force-pushed
the
save-bytes-as-file
branch
from
53a6021 to
5e2b8ed
Compare
catap
changed the title
catap
force-pushed
the
save-bytes-as-file
branch
2 times, most recently
from
0d90a27 to
46da6eb
Compare
catap
force-pushed
the
save-bytes-as-file
branch
from
46da6eb to
d950c0c
Compare
ddworak
reviewed
Dec 6, 2020
guide/guide/.js/src/main/scala/io/udash/web/guide/views/frontend/demos/FileInputDemo.scala
Outdated
Show resolved
Hide resolved
ddworak
reviewed
Dec 6, 2020
guide/guide/.js/src/main/scala/io/udash/web/guide/views/frontend/demos/FileInputDemo.scala
Show resolved
Hide resolved
catap
force-pushed
the
save-bytes-as-file
branch
from
d950c0c to
9b86e13
Compare
catap
force-pushed
the
save-bytes-as-file
branch
from
9b86e13 to
0111442
Compare
ddworak
reviewed
Dec 7, 2020
ddworak
approved these changes
Dec 7, 2020
The usecase of this code is something like this: let image that user is making a protonmail or any another application where content inside frontend (=browser storage) some secret user's data that shouldn't be exposed to backend. Secret key for example or anything like that. This code allows to developer to convert any `Seq[Array[Byte]]` from frontend to URL as simple call `FileService.createURL`, asynchronously convert any uploaded `File` to `Future[Array[Byte]]` as `FileService.asBytesArray`, or to `Array[Byte]` via `FileService.asSyncBytesArray` inside worker. Unfortunately scalatags doesn't support `download` attribute and I need to make it by hand. I've opened a PR[^1] to introduce it, but it might be a while until it is included to release. `FileService.asSyncBytesArray` is using `FileReaderSync` that is also missed inside scala-js-dom. I've opened a PR[^2] but it might be a while. Also, this draft API but it is supported by majority of modern browsers[^3]. [^1]: com-lihaoyi/scalatags#212 [^2]: scala-js/scala-js-dom#424 [^3]: https://caniuse.com/?search=FileReaderSync
catap
force-pushed
the
save-bytes-as-file
branch
from
0111442 to
9c1d9a2
Compare
|
@ddworak pushed renaming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usecase of this code is something like this: let image that user is making a protonmail or any another application where content inside frontend (=browser storage) some secret user's data that shouldn't be exposed to backend. Secret key for example or anything like that.
This code allows to developer to convert any
Seq[Array[Byte]]from frontend to URL as simple callFileService.createURL, asynchronously convert any uploadedFiletoFuture[Array[Byte]]asFileService.asBytesArray, or toArray[Byte]viaFileService.asSyncBytesArrayinside worker.Unfortunately scalatags doesn't support
downloadattribute and I need to make it by hand. I've opened a PR1 to introduce it, but it might be a while until it is included to release.FileService.asSyncBytesArrayis usingFileReaderSyncthat is also missed inside scala-js-dom. I've opened a PR2 but it might be a while. Also, this draft API but it is supported by majority of modern browsers3.Footnotes
https://github.com/lihaoyi/scalatags/pull/212 ↩
https://github.com/scala-js/scala-js-dom/pull/424 ↩
https://caniuse.com/?search=FileReaderSync ↩