Added tests and bug fixes for things found by tests. #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smaillet
commented
May 4, 2020
smaillet
commented
- Added new tests for DIBuilder (Biggest impact of nullability changes)
- These tests have necessitated diving deep into the LLVM implementation to determine if null is truly allowed or not, with some surprising explicit allow cases.
- Fixed bugs in nullability of parameter declarations and arg validation.
- General pattern is for things to be not nullable if possible, and allow null for in params as needed but have a default for out or returns whenever plausible.
- In particular, strings as out or return will be string.Empty instead of null, unless LLVM defines a semantic difference between the null and empty values. (So far there's no known case of that)
- General pattern is for things to be not nullable if possible, and allow null for in params as needed but have a default for out or returns whenever plausible.
- Simplified DOCFX projects by leveraging the under documented PackageReference 'GeneratePathProperty' to identify the root path of the package with a property
* Added new tests for DIBuilder (Biggest impact of nullability changes)
- These tests have necessitated diving deep into the LLVM implementation to determine if null is truly allowed or not, with some surprising explicit allow cases.
* Fixed bugs in nullability of parameter declarations and arg validation.
- General pattern is for things to be not nullable if possible, and allow null for in params as needed but have a default for out or returns whenever plausible.
* In particular, strings as out or return will be string.Empty instead of null, unless LLVM defines a semantic difference between the null and empty values. (So far there's no known case of that)
* Simplified DOCFX projects by leveraging the under documented PackageReference 'GeneratePathProperty' to identify the root path of the package with a property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.