-
Notifications
You must be signed in to change notification settings - Fork 437
Add guide for Rocket.Chat #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
luto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this guide! Despite the complexity, it is nice and easy to follow. I left a few comments to streamline it for less-experienced users.
source/guide_rocketchat.rst
Outdated
|
|
||
| :: | ||
|
|
||
| [isabell@stardust ~]$ uberspace web backend set / --http --port 3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an include for web backends, used like this. Can you please change this to match?
|
|
||
| This is required because Rocket.Chat uses Meteor Oplog Tailing for performance improvements (see `the docs <https://rocket.chat/docs/installation/manual-installation/mongo-replicas/>`_ for further information). | ||
|
|
||
| Then tell supervisord to update and start the service: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably also needs supervisorctl reread to reload the config file.
source/guide_rocketchat.rst
Outdated
|
|
||
| [program:rocket.chat] | ||
| command=node %(ENV_HOME)s/rocket.chat/main.js | ||
| environment=MONGO_URL="mongodb://<username>_rocketchat:<password>@localhost:27017/rocketchat?replicaSet=rs01&authSource=admin",MONGO_OPLOG_URL="mongodb://<username>_rocketchat:<password>@localhost:27017/local?replicaSet=rs01&authSource=admin",ROOT_URL="https://<username>.uber.space/",PORT=3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this into multiple lines (one per var), like in the synapse guide.
source/guide_rocketchat.rst
Outdated
|
|
||
| :: | ||
|
|
||
| [isabell@stardust ~]$ mongo --username <username>_mongoroot --eval "printjson(rs.initiate())" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mongodb guide suggest to use the uberspace username as <username>, so I think we can replace all <username>_mongoroot with ${USER}_mongoroot to make the guide easier to follow.
source/guide_rocketchat.rst
Outdated
|
|
||
| [program:rocket.chat] | ||
| command=node %(ENV_HOME)s/rocket.chat/main.js | ||
| environment=MONGO_URL="mongodb://<username>_rocketchat:<password>@localhost:27017/rocketchat?replicaSet=rs01&authSource=admin",MONGO_OPLOG_URL="mongodb://<username>_rocketchat:<password>@localhost:27017/local?replicaSet=rs01&authSource=admin",ROOT_URL="https://<username>.uber.space/",PORT=3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using %(ENV_USER)s_rocketchat here to reduce the number of things to manually replace?
| Using 'Node.js' version: '12' | ||
| [isabell@stardust ~]$ | ||
|
|
||
| We'll also need :lab:`MongoDB <guide_mongodb>`, so follow the MongoDB guide and come back when it's running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we feature this more prominently? Maybe add it to the "familiar with the basic concepts of"-list? put it into a note box? List it as the first (or last) prerequisite?
source/guide_rocketchat.rst
Outdated
|
|
||
| :: | ||
|
|
||
| [isabell@stardust ~]$ uberspace web domain list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like web backends, there is also an include for this.
|
Thanks for the feedback! I'll change the guide accordingly. |
the environment variable in the rocket.chat.ini is now split into multiple lines, one per variable
reread the config for mongo after updating
Moved the web backend configuration to the Configuration section and used the web-backend include
- forgot a shell prompt at the end of a listing - added missing colon - improved note for service ini
|
Damn. I've fixed everything but upon testing I stumbled over RocketChat/Rocket.Chat#7465, this didn't happen on my other tests. I'll update the PR when I find a reasonable solution. |
|
I think I've found a solution that's not too bad 😅 . I've also fixed all points you mentioned. |
<username> mention not required
|
Would you like to try to submit your |
|
Yes, fixing this in Rocket.Chat would be nicer of course. I just figured that a breaking change is unlikely here since the change is not in Rocket.Chat but the UploadFS package, which is deprecated (see https://github.com/jalik/meteor-jalik-ufs#uploadfs) and is unlikely to change much. But regardless of that I'll have a look at the Rocket.Chat code... well, that escalated quickly 😁 |
|
Hi and thanks a lot for this guide - just what I was looking for :) |
|
Hi, you can view the full guide in the netlify preview: https://deploy-preview-585--uberlab.netlify.com/guide_rocketchat.html. But here is the content for this file: |
|
I've made a PR in Rocket.Chat, lets see what happens 😅 |
|
Perfect, thank you! It worked and I'm up and running :) |
|
Thank you very much for all the work and the upstream PR! 🎉 |
|
@d-sko I can't find your mail address. Please write us an email to hallo@uberspace.de for your reward :) |
Hi, I've added a guide for Rocket.Chat.
closes #584