Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-528] Make cluster point process code more general by fixing hard coded values #579

Merged
merged 4 commits into from
Dec 30, 2023
Merged

[ISSUE-528] Make cluster point process code more general by fixing hard coded values #579

merged 4 commits into from
Dec 30, 2023

Conversation

jcholol
Copy link
Contributor

@jcholol jcholol commented Dec 18, 2023

closes #528

  • Added Python GUI using PyQT5 (handles input errors)
  • Removed "magic numbers" refactoring the hard-coded parameters to be more general, parameters are now user-inputted values from the GUI (no longer specific to a simulation).
  • Reorganized files (cluster_point_process_functions.py has the functionalities, cluster_point_process.py has the GUI)
  • output files (XML) are generalized, descriptions in the XMLs also reflect this.

@jcholol jcholol merged commit 4878e21 into development Dec 30, 2023
1 check passed
@jcholol jcholol deleted the issue-528-make-cluster-point-more-general branch December 30, 2023 18:50
stiber pushed a commit that referenced this pull request Feb 17, 2024
@jcholol @stiber
Merge pull request #579 from UWB-Biocomputing/issue-528-make-cluster-…
a5155ee 
…point-more-general

[ISSUE-528] Make cluster point process code more general by fixing hard coded values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiber stiber stiber approved these changes

@jardiamj jardiamj Awaiting requested review from jardiamj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcholol @stiber