-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significantly improve climbing (and add RaycastSweep API along the way) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The x-size of the climbing hitbox is now 0.25 meters instead of 0.2 meters. This should hopefully make climbing a little more lenient.
This gives RaycastSweep a method for updating raycast layout based on changes to some of its variables.
From the last commit that modified RaycastSweep, I meant to say "improve RaycastSweep documentation". This is still not really true since I messed up the definition of median in that commit, and had to do a Google search to figure out what it really meant.
To make the method more clear about what it actually does, it's name was changed to "PerformSweep" and more was added to its documentation.
this took way too long
This change makes it so your character can climb an object at more angles.
Being too close to the climbable object should no longer cause your character to not be able to climb up or down.
Your character should now be able to rotate while rapid-climbing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
This took way too long. But finally, a lot of the problems with climbing have been fixed as a result of this pull request.
In addition, Jumpvalley's new RaycastSweep API was made along the way to help make these fixes.