Gcc8 warnings fixes #527
Open
Gcc8 warnings fixes #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSoptics
force-pushed
the
gcc8_warnings_fixes
branch
from
7f0b318 to
f703acd
Compare
|
(The check failing is also present in the develop branch and not related to the merge request: https://ci.appveyor.com/project/AzothAmmo/cereal/branch/develop/job/61eo08pu3rm87ej7/messages) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps gcc8 from suggesting that
base_class_id_hash::operator()be markednoexceptas well as from remarking that the case from typechar *toheader *increases the alignment requirements. (The latter is per se a correct warning, but rapidxml makes sure the alignment is correct by hand, which the compiler can't know.)