Change StaticObject instance management to hopefully avoid UBSAN#470
Merged
Conversation
The static-object hack currently used requires passing an uninitialized reference as a reference. This fix uses a cast to void to hopefully avoid that undefined behavior.
|
Have you tested if this would get optimized by the compiler when optimizations are enabled? |
Contributor
|
@volcoma The CI checks are done with optimization on; for Windows we run both a debug build and a release (optimized) build. If it's passing those everything should in theory be good, but I'll check this one out locally first to double check. |
Contributor
|
Seems like this still works; if it blows up down the line we can easily revert the change. |
WSoptics
pushed a commit
to WSoptics/cereal
that referenced
this pull request
Mar 23, 2018
WSoptics
pushed a commit
to WSoptics/cereal
that referenced
this pull request
Mar 23, 2018
jrmadsen
pushed a commit
to jrmadsen/cereal
that referenced
this pull request
Jul 7, 2019
jrmadsen
pushed a commit
to jrmadsen/cereal
that referenced
this pull request
Jul 7, 2019
JerryRyan
pushed a commit
to JerryRyan/cereal
that referenced
this pull request
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static-object hack currently used requires passing an
uninitialized reference as a reference. This fix uses a cast
to void to hopefully avoid that undefined behavior.