-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json/XML Archive improvement #321
base: master
Are you sure you want to change the base?
Conversation
…still CEREAL_XML_STRING_VALUE
Can you clarify the NVP exception changes you've made here? We already throw an exception ( |
Yes this catches more errors, f.e. when rapidjson can't parse a value cause of a type-mismatch it throws an exception, so this would give you more info. (Though I'm seeing now you modified rapidjson to throw an cereal::Exception, so i guess it would be ok to change the catch in the json archive to cereal::Exception, the xml archive though uses the std::stoll (and similar) functions to parse the values which throw std::exception so i wouldn't change the catch there).
|
any news here? a configurable root node would be helpful. |
Better error messages when loading of nvp fails. You can now see the complete path of nvps that fails which helps if you're parsing big xml/json archives with nested data structures.
The name of the root node in the xml can now be configured on a per archive basis (default is the one set with the CEREAL_XML_STRING_VALUE macro, so no everything should work as before) which is easier than the macro (which is not always possible if you want to use different root names and polymorphism support).