Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pwa-ea): placeholder for sorting modal exposure assessment #406

Merged
merged 43 commits into from
Sep 10, 2024

Conversation

kennethliporada
Copy link
Collaborator

Description

  • added placeholder name 'Sort of:'
  • rearrange width search and sorting button

#Screenshot
image

pfgoting and others added 30 commits October 5, 2021 21:51
Added github actions workflow for auto deployment to both s3 and asti servers
Changed to staging. Created branch for staging.
# Summary 

- Fixes #186
- The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once.
  - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH
- Confirming that only the NOAH Studio is affected by this issue.
 
# Demo

![Kapture 2021-10-05 at 22 49 45](https://user-images.githubusercontent.com/11599005/136047077-d0da7a85-9157-4d01-bae9-07a6039fd9c1.gif)
* Added if condition to run workflow only on successful PR merge. (#195)

* Checking proper automation workflow. Will revert this small change upon validation. (#196)
* Checking proper automation workflow. Will revert this small change upon validation.

* Changed trigger for deployment workflow. Revert small change to bibliography.
* Added AWS deployment workflow
@kennethliporada kennethliporada added the pwa Progressive Working App label Sep 6, 2024
@kennethliporada kennethliporada self-assigned this Sep 6, 2024
Copy link
Collaborator

@bon-carpo bon-carpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for qa

@bon-carpo bon-carpo merged commit 0cb83ad into staging-pwa Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pwa Progressive Working App
Projects
Development

Successfully merging this pull request may close these issues.

4 participants