Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(studio)(qc-iot)(qc-sensor-details)[PWA]: Design mobile view for IoT popup details #398

Merged
merged 11 commits into from
Aug 15, 2024
Merged

feat(studio)(qc-iot)(qc-sensor-details)[PWA]: Design mobile view for IoT popup details #398

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
66fd181
modified popup for mobile and non mobile view, popup to be moved to c…
ramoncomendadorjr Jul 25, 2024
80ff612
added text color indicator to the popup which to be made into onclick
ramoncomendadorjr Jul 25, 2024
753ddfa
sensor details still on mouseover
ramoncomendadorjr Jul 26, 2024
3025f49
added if condition in mobile, shows sensor details on tap, a graph on…
ramoncomendadorjr Jul 26, 2024
c52d3a4
adjusted popup to have space for sensor detail graph, alternative is …
ramoncomendadorjr Jul 29, 2024
77d4d51
added todo comment
ramoncomendadorjr Jul 29, 2024
a04dc2a
added graph to popup, made new qcchart function for mobile view
ramoncomendadorjr Jul 29, 2024
0e15c4b
adjusted default zoom placement of sensor detail popup for mobile view
ramoncomendadorjr Jul 29, 2024
a19f7b9
updated font family used and font size of sensor details
ramoncomendadorjr Jul 29, 2024
4f2dc70
reverted popup.removed() for non-mobile screens
ramoncomendadorjr Jul 30, 2024
b5e36a1
adjusted category text color
ramoncomendadorjr Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reverted popup.removed() for non-mobile screens
  • Loading branch information
@ramoncomendadorjr
ramoncomendadorjr committed Aug 8, 2024
commit 4f2dc707e1ee5452eed7e3a7c3c40ead0548a919
12 changes: 5 additions & 7 deletions src/app/features/noah-playground/components/map-playground/map-playground.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,10 +675,6 @@ export class MapPlaygroundComponent implements OnInit, OnDestroy {
}
popUp.setLngLat(coordinates).setHTML(
`
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Inter:wght@100..900&display=swap" rel="stylesheet">

<div style="color: #333333;font-size: 13px;padding-top: 4px;">
<div><b>Name:</b> ${name} </div>
<div><b>IoT Sensor Type:</b> ${iotType}</div>
Expand Down Expand Up @@ -714,7 +710,8 @@ export class MapPlaygroundComponent implements OnInit, OnDestroy {
});
}
} else {
// popUp.remove();
popUp.remove();
popUpMobileView.remove();
chartPopUp.remove();
this.map.on('mouseenter', qcSensorType, (e) => {
_this._graphShown = false;
Expand All @@ -725,16 +722,17 @@ export class MapPlaygroundComponent implements OnInit, OnDestroy {
this.map.on('mouseleave', qcSensorType, (e) => {
_this._graphShown = false;
_this.map.getCanvas().style.cursor = '';
// popUp.remove();
popUp.remove();
chartPopUpOpen = false;
});
}
});
popUp.on('close', () => (_this._graphShown = false));
popUpMobileView.on('close', () => (_this._graphShown = false));
this.map.on('mouseleave', qcSensorType, function () {
if (_this._graphShown) return;
_this.map.getCanvas().style.cursor = '';
// popUp.remove();
popUp.remove();
});
}

Expand Down