Skip to content

added partial solution #47

added partial solution

added partial solution #47

Re-run triggered January 21, 2024 12:58
Status Failure
Total duration 51s
Artifacts

ci.yml

on: pull_request
Matrix: build_and_test
Matrix: static_checks
Fit to window
Zoom out
Zoom in

Annotations

42 errors
build_and_test (ubuntu-latest, x86_64-unknown-linux-gnu, nightly, true)
Process completed with exit code 101.
static_checks (ubuntu-latest, wasm32-wasi): src/editor.rs#L35
[clippy-wasm32-wasi] reported by reviewdog 🐶 <pre><code>error: writing `&String` instead of `&str` involves a new object where a slice will do --> src/editor.rs:35:19 | 35 | fn dsp_width(msg: &String) -> usize { UnicodeWidthStr::width(msg.as_str()) + 1 } | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]` help: change this to | 35 | fn dsp_width(msg: &str) -> usize { UnicodeWidthStr::width(msg) + 1 } | ~~~~ ~~~ </code></pre> Raw Output: src/editor.rs:35:19:e: <pre><code>error: writing `&String` instead of `&str` involves a new object where a slice will do --> src/editor.rs:35:19 | 35 | fn dsp_width(msg: &String) -> usize { UnicodeWidthStr::width(msg.as_str()) + 1 } | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]` help: change this to | 35 | fn dsp_width(msg: &str) -> usize { UnicodeWidthStr::width(msg) + 1 } | ~~~~ ~~~ </code></pre> __END__
static_checks (ubuntu-latest, wasm32-wasi): src/editor.rs#L842
[clippy-wasm32-wasi] reported by reviewdog 🐶 <pre><code>error: initializer for `thread_local` value can be made `const` --> src/editor.rs:842:53 | 842 | thread_local! (static CHARACTER: RefCell<Vec<u8>> = {let cache = Vec::new(); RefCell::new(cache)}); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { {let cache = Vec::new(); RefCell::new(cache)} }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]` </code></pre> Raw Output: src/editor.rs:842:53:e: <pre><code>error: initializer for `thread_local` value can be made `const` --> src/editor.rs:842:53 | 842 | thread_local! (static CHARACTER: RefCell<Vec<u8>> = {let cache = Vec::new(); RefCell::new(cache)}); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { {let cache = Vec::new(); RefCell::new(cache)} }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]` </code></pre> __END__
static_checks (ubuntu-latest, wasm32-wasi): src/editor.rs#L855
[clippy-wasm32-wasi] reported by reviewdog 🐶 <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:855:5 | 855 | character.clone().map_or((), |c| buffer.push_str(c.as_str())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead = note: `-D unused-must-use` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_must_use)]` help: use `let _ = ...` to ignore the resulting value | 855 | let _ = character.clone().map_or((), |c| buffer.push_str(c.as_str())); | +++++++ </code></pre> Raw Output: src/editor.rs:855:5:e: <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:855:5 | 855 | character.clone().map_or((), |c| buffer.push_str(c.as_str())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead = note: `-D unused-must-use` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_must_use)]` help: use `let _ = ...` to ignore the resulting value | 855 | let _ = character.clone().map_or((), |c| buffer.push_str(c.as_str())); | +++++++ </code></pre> __END__
static_checks (ubuntu-latest, wasm32-wasi): src/editor.rs#L856
[clippy-wasm32-wasi] reported by reviewdog 🐶 <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:856:5 | 856 | character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead help: use `let _ = ...` to ignore the resulting value | 856 | let _ = character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | +++++++ </code></pre> Raw Output: src/editor.rs:856:5:e: <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:856:5 | 856 | character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead help: use `let _ = ...` to ignore the resulting value | 856 | let _ = character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | +++++++ </code></pre> __END__
build_and_test (ubuntu-latest, wasm32-wasi, nightly, true)
Process completed with exit code 101.
build_and_test (ubuntu-latest, wasm32-wasi)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (ubuntu-latest, wasm32-wasi)
Process completed with exit code 101.
build_and_test (windows-latest, x86_64-pc-windows-gnu, 1.64.0)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (windows-latest, x86_64-pc-windows-gnu, 1.64.0)
The operation was canceled.
build_and_test (ubuntu-latest, x86_64-unknown-linux-musl)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (ubuntu-latest, x86_64-unknown-linux-musl)
The operation was canceled.
build_and_test (windows-latest, x86_64-pc-windows-gnu)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (windows-latest, x86_64-pc-windows-gnu)
The operation was canceled.
static_checks (ubuntu-latest, x86_64-unknown-linux-gnu): src/editor.rs#L35
[clippy-x86_64-unknown-linux-gnu] reported by reviewdog 🐶 <pre><code>error: writing `&String` instead of `&str` involves a new object where a slice will do --> src/editor.rs:35:19 | 35 | fn dsp_width(msg: &String) -> usize { UnicodeWidthStr::width(msg.as_str()) + 1 } | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]` help: change this to | 35 | fn dsp_width(msg: &str) -> usize { UnicodeWidthStr::width(msg) + 1 } | ~~~~ ~~~ </code></pre> Raw Output: src/editor.rs:35:19:e: <pre><code>error: writing `&String` instead of `&str` involves a new object where a slice will do --> src/editor.rs:35:19 | 35 | fn dsp_width(msg: &String) -> usize { UnicodeWidthStr::width(msg.as_str()) + 1 } | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]` help: change this to | 35 | fn dsp_width(msg: &str) -> usize { UnicodeWidthStr::width(msg) + 1 } | ~~~~ ~~~ </code></pre> __END__
static_checks (ubuntu-latest, x86_64-unknown-linux-gnu): src/editor.rs#L842
[clippy-x86_64-unknown-linux-gnu] reported by reviewdog 🐶 <pre><code>error: initializer for `thread_local` value can be made `const` --> src/editor.rs:842:53 | 842 | thread_local! (static CHARACTER: RefCell<Vec<u8>> = {let cache = Vec::new(); RefCell::new(cache)}); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { {let cache = Vec::new(); RefCell::new(cache)} }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]` </code></pre> Raw Output: src/editor.rs:842:53:e: <pre><code>error: initializer for `thread_local` value can be made `const` --> src/editor.rs:842:53 | 842 | thread_local! (static CHARACTER: RefCell<Vec<u8>> = {let cache = Vec::new(); RefCell::new(cache)}); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { {let cache = Vec::new(); RefCell::new(cache)} }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]` </code></pre> __END__
static_checks (ubuntu-latest, x86_64-unknown-linux-gnu): src/editor.rs#L855
[clippy-x86_64-unknown-linux-gnu] reported by reviewdog 🐶 <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:855:5 | 855 | character.clone().map_or((), |c| buffer.push_str(c.as_str())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead = note: `-D unused-must-use` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_must_use)]` help: use `let _ = ...` to ignore the resulting value | 855 | let _ = character.clone().map_or((), |c| buffer.push_str(c.as_str())); | +++++++ </code></pre> Raw Output: src/editor.rs:855:5:e: <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:855:5 | 855 | character.clone().map_or((), |c| buffer.push_str(c.as_str())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead = note: `-D unused-must-use` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_must_use)]` help: use `let _ = ...` to ignore the resulting value | 855 | let _ = character.clone().map_or((), |c| buffer.push_str(c.as_str())); | +++++++ </code></pre> __END__
static_checks (ubuntu-latest, x86_64-unknown-linux-gnu): src/editor.rs#L856
[clippy-x86_64-unknown-linux-gnu] reported by reviewdog 🐶 <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:856:5 | 856 | character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead help: use `let _ = ...` to ignore the resulting value | 856 | let _ = character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | +++++++ </code></pre> Raw Output: src/editor.rs:856:5:e: <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:856:5 | 856 | character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead help: use `let _ = ...` to ignore the resulting value | 856 | let _ = character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | +++++++ </code></pre> __END__
build_and_test (windows-latest, i686-pc-windows-msvc)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (windows-latest, i686-pc-windows-msvc)
The operation was canceled.
build_and_test (macos-latest, x86_64-apple-darwin, 1.64.0)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (macos-latest, x86_64-apple-darwin, 1.64.0)
The operation was canceled.
build_and_test (windows-latest, x86_64-pc-windows-gnu, nightly, true)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (windows-latest, x86_64-pc-windows-gnu, nightly, true)
The operation was canceled.
build_and_test (macos-latest, x86_64-apple-darwin, nightly, true)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (macos-latest, x86_64-apple-darwin, nightly, true)
The operation was canceled.
build_and_test (ubuntu-latest, x86_64-unknown-linux-gnu)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (ubuntu-latest, x86_64-unknown-linux-gnu)
The operation was canceled.
build_and_test (macos-latest, x86_64-apple-darwin)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (macos-latest, x86_64-apple-darwin)
The operation was canceled.
build_and_test (ubuntu-latest, i686-unknown-linux-gnu)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (ubuntu-latest, i686-unknown-linux-gnu)
The operation was canceled.
build_and_test (windows-latest, x86_64-pc-windows-msvc)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (windows-latest, x86_64-pc-windows-msvc)
The operation was canceled.
static_checks (macos-latest, x86_64-apple-darwin): src/editor.rs#L35
[clippy-x86_64-apple-darwin] reported by reviewdog 🐶 <pre><code>error: writing `&String` instead of `&str` involves a new object where a slice will do --> src/editor.rs:35:19 | 35 | fn dsp_width(msg: &String) -> usize { UnicodeWidthStr::width(msg.as_str()) + 1 } | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]` help: change this to | 35 | fn dsp_width(msg: &str) -> usize { UnicodeWidthStr::width(msg) + 1 } | ~~~~ ~~~ </code></pre> Raw Output: src/editor.rs:35:19:e: <pre><code>error: writing `&String` instead of `&str` involves a new object where a slice will do --> src/editor.rs:35:19 | 35 | fn dsp_width(msg: &String) -> usize { UnicodeWidthStr::width(msg.as_str()) + 1 } | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]` help: change this to | 35 | fn dsp_width(msg: &str) -> usize { UnicodeWidthStr::width(msg) + 1 } | ~~~~ ~~~ </code></pre> __END__
static_checks (macos-latest, x86_64-apple-darwin): src/editor.rs#L842
[clippy-x86_64-apple-darwin] reported by reviewdog 🐶 <pre><code>error: initializer for `thread_local` value can be made `const` --> src/editor.rs:842:53 | 842 | thread_local! (static CHARACTER: RefCell<Vec<u8>> = {let cache = Vec::new(); RefCell::new(cache)}); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { {let cache = Vec::new(); RefCell::new(cache)} }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]` </code></pre> Raw Output: src/editor.rs:842:53:e: <pre><code>error: initializer for `thread_local` value can be made `const` --> src/editor.rs:842:53 | 842 | thread_local! (static CHARACTER: RefCell<Vec<u8>> = {let cache = Vec::new(); RefCell::new(cache)}); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { {let cache = Vec::new(); RefCell::new(cache)} }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]` </code></pre> __END__
static_checks (macos-latest, x86_64-apple-darwin): src/editor.rs#L855
[clippy-x86_64-apple-darwin] reported by reviewdog 🐶 <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:855:5 | 855 | character.clone().map_or((), |c| buffer.push_str(c.as_str())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead = note: `-D unused-must-use` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_must_use)]` help: use `let _ = ...` to ignore the resulting value | 855 | let _ = character.clone().map_or((), |c| buffer.push_str(c.as_str())); | +++++++ </code></pre> Raw Output: src/editor.rs:855:5:e: <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:855:5 | 855 | character.clone().map_or((), |c| buffer.push_str(c.as_str())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead = note: `-D unused-must-use` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_must_use)]` help: use `let _ = ...` to ignore the resulting value | 855 | let _ = character.clone().map_or((), |c| buffer.push_str(c.as_str())); | +++++++ </code></pre> __END__
static_checks (macos-latest, x86_64-apple-darwin): src/editor.rs#L856
[clippy-x86_64-apple-darwin] reported by reviewdog 🐶 <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:856:5 | 856 | character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead help: use `let _ = ...` to ignore the resulting value | 856 | let _ = character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | +++++++ </code></pre> Raw Output: src/editor.rs:856:5:e: <pre><code>error: unused return value of `std::result::Result::<T, E>::map_or` that must be used --> src/editor.rs:856:5 | 856 | character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if you don't need the returned value, use `if let` instead help: use `let _ = ...` to ignore the resulting value | 856 | let _ = character.map_or((), |_| CHARACTER.with(|cache| cache.borrow_mut().clear())); | +++++++ </code></pre> __END__
build_and_test (ubuntu-latest, wasm32-wasi, 1.64.0)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (ubuntu-latest, wasm32-wasi, 1.64.0)
The operation was canceled.
build_and_test (ubuntu-latest, x86_64-unknown-linux-gnu, 1.64.0)
The job was canceled because "ubuntu-latest_x86_64-un_4" failed.
build_and_test (ubuntu-latest, x86_64-unknown-linux-gnu, 1.64.0)
The operation was canceled.