Create an tbf parsing crate #1

[mihai-negru]

Pull Request Overview

The idea of this pull request is to set the foundation for building a rust version of tockloader. The arguments for this are:

• pip is not very portable when it comes to installing commands, it sometimes works just with pip, otherwise it needs pip --user or sudo.
• unifying the tools and libraries used for tock, so that we do not use two programming languages

Created a new workspace

• Workspace at the root level
• Two containing members elf2tab and tbfparser

Modifications in the elf2tab

• Removed the header.rs file and added to a new created crate
• Removed the utils.rs file because it can be found at the tbfparser library
• Modified Cargo.toml dependencies by adding the new created crate, the path is specified relative to the root project folder.
• Replaced the header file to tbfparser package.

Creating the new library crate tbfparser

• Created a library cargo crate.
• Moved header.rs to the lib.rs.
• Copied utils.rs in the src folder of the current crate.

Testing Strategy

This pull request was tested by compiling.
Copiled the project in the workspace using cargo build, resulting in elf2tab elf file.

TODO or Help Wanted

N/A

Documentation Updated

Added a new subsubsection in the elf2tabDetails to describe the project's structure. (workflow)

[alexandruradovici]

The tbf parser should be in its own crate, different from elf2tab. I would create a wrokspace in the root folder (https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html) and place the two crates, elf2tab and tbfparser, in the workspace. Adapt the readme to this.

[mihai-negru]

The tbf parser should be in its own crate, different from elf2tab. I would create a wrokspace in the root folder (https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html) and place the two crates, elf2tab and tbfparser, in the workspace. Adapt the readme to this.

I have created the workspace and moved both crates into the workspace. Also updated the readme file for compilation instructions.

[alexandruradovici]

I would move the workspace to the root.

[mihai-negru]

I would move the workspace to the root.

I have moved the workspace to the root level and removed the utils.rs from the elf2tab crate, to remove code duplication (utils.rs can be also found in the tbfparser crate as a public module). However I do not find something in the README file to modify, should I create a new section to write explicity that the repository contains one workspace with two crates?

P.S: I have also edited the PR overview

[alexandruradovici]

However I do not find something in the README file to modify, should I create a new section to write explicity that the repository contains one workspace with two crates?

I think this is a good solution.

[mihai-negru]

However I do not find something in the README file to modify, should I create a new section to write explicity that the repository contains one workspace with two crates?

I think this is a good solution.

I created a subsubsection under the Details section from the README and described very shortly how the project is structured.

[alexandruradovici]

Formatting fails, please run cargo fmt on all the crates.

[mihai-negru]

Formatting fails, please run cargo fmt on all the crates.

Running cargo fmt --check on my machine seems to work

[alexandruradovici]

Please open a pull request to the upstream repository and post here a link.

[mihai-negru]

Sorry for the question, how can I open the pull request from a fork that is forked from the main repository? Or it should be merged to this upstream firstly and then to the main repository. Thanks for the answer

[alexandruradovici]

Open a new pull request and select the upstream (original) repository. You should have a dropdown there.

[mihai-negru]

Link to the pull request : tock#62

[mihai-negru]

Hello, sorry for the question. I wanted to ask if is anything more to do on this pull request, I do not seem to understand what I should do next by reading the bradjc's comment from the main stream. Thanks in advice!

[alexandruradovici]

What Brad was suggesting is that you take a look at tock-tbf crate and see if we can merge this. This may or not be possible, as tock-tbf does not depend on the std crate (#[no-std]) and is not able to use memory allocation.

[alexandruradovici]

Any update here?

[mihai-negru]

Any update here?

I have looked over the tock-tbf and revised the tbfparser and for me, it seems impossible to modify the tbfparser code in order no to use the standard library (#no-std), as suggested bradjc creating a separate repository just for the tbfparser would make the deal.

[alexandruradovici]

One approach would be to use the data types from the tbf crate defined in tock instead of redefining them. What about adding the crate in the tock repository, next to the tbf parser?

[mihai-negru]

I closed the last pull request and I will work on the new idea that you have suggested, on using the types defined in the tock/libraries/tbfparser

One approach would be to use the data types from the tbf crate defined in tock instead of redefining them. What about adding the crate in the tock repository, next to the tbf parser?