Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printf infinite loop #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix printf infinite loop #8

wants to merge 4 commits into from
+28 −4

Conversation

alx-sima
Copy link

@alx-sima alx-sima commented Jan 11, 2024 •
edited
Loading

Fix printf infinite loop (#5818) while there are more parameters than format arguments.

Still WiP:

  • print stdout before stderr
  • add test

@sudhackar
Copy link

The current change would also break this.

$ printf %c a b c d e
abcde

@alx-sima
Copy link
Author

@sudhackar this should be fixed now. Passing all the tests.

@alexandruradovici
Copy link

alexandruradovici commented Jan 15, 2024 •
edited
Loading

Please rebase it, make sure to run cargo fmt on your code, send this to upstream and place a link to it here.

@alexandruradovici alexandruradovici marked this pull request as ready for review January 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alx-sima @sudhackar @alexandruradovici