Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging + repo reorg #26

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Logging + repo reorg #26

merged 10 commits into from
Oct 18, 2022

Conversation

prakaa
Copy link
Contributor

@prakaa prakaa commented Sep 27, 2022

Minor feature:

  • Move warnings, user feedback, etc. to logging. Doing so will allow feedback to be silenced in say a Jupyter notebook via:
import logging
logging.getLogger().setLevel(logging.ERROR)

Code style:

  • All code autoformatted using black
  • Relative imports within module

Repo org

  • Deleted smoke test script
  • Moved tests to tests/
  • Query wrapers to Query wrappers

Closes #25

@prakaa
Copy link
Contributor Author

prakaa commented Oct 14, 2022

@nick-gorman, sorry about that logging error. Fixed up now, so logging.getLogger("nemosis").setLevel(logging.WARNING) should work now

@nick-gorman
Copy link
Member

Thanks for adding this functionality @prakaa

I've updated the tests for the bidding data because AEMO's window of which bidding files are uploaded to nemweb has changed since we last tested. Now all tests are passing.

I've also added an example of how to disable logging to the readme.

@nick-gorman nick-gorman merged commit 87283b2 into UNSW-CEEM:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate user warnings to logging, instead of printing
2 participants