feat(23-UG20): реализовать API смены пароля #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakhovRoman
requested review from
cap-Bernardito,
AleksandrMenshchikov,
KozlovAleksandr and
EAbashin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cap-Bernardito
approved these changes
Apr 9, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
AleksandrMenshchikov
approved these changes
Apr 10, 2023
Olegas
requested changes
Apr 10, 2023
|
|
||
| useEffect(() => { | ||
| if (isSuccess.password) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Вот здесь я бы предусмотрел отмену этого таймера на случай, если за 3 секунды пользователь перейдет на какую-то другую страницу.
There was a problem hiding this comment.
Добавил отмену таймера и очистку формы
| @@ -53,6 +59,10 @@ export const userThunks = { | |||
| const newUser = await userAPI.changeUserProfile(data); | |||
| dispatch(authSlice.actions.setUser(newUser)); | |||
| }), | |||
| changeUserPassword: createAsyncThunk( | |||
| "USER/password", | |||
| async (data: PasswordChangeRequest) => await userAPI.changeUserPassword(data) | |||
There was a problem hiding this comment.
Не делайте return await - эта конструкция не имеет никакого смысла. Можно смело убрать тут async/await и ничего не изменится
Olegas
approved these changes
Apr 10, 2023
KozlovAleksandr
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Какую задачу решаем
Реализация API смены пароля