Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testex3 #181

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lorenzodidomenic
Copy link

No description provided.

@@ -0,0 +1,17 @@
def func(k:str):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manca il return type della funzione

def func(k: str) -> str:
    # ....

@Picred
Copy link
Collaborator

Picred commented Nov 20, 2023

  • Potresti mettere una breve descrizione della Pull Request (anche se in casi come questi è banale, è utile abituarsi a farlo, eventualmente)
  • I test non vengono controllati dalla pipeline. Il coverage di ex3.py è 0%
  • Secondo me sarebbe stato meglio creare una nuova branch per l'esercizio ex3.py assicurandole una singola responsabilità

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants