Calculator test #175
Open
Calculator test #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hai inviato un file vuoto. Controlla che il file aggiunto venga effettivamente "tracciato" con |
| def mul(a: int, b: int)-> int: | ||
| return a*b | ||
|
|
||
| def div(a: int, b:int)-> int: |
There was a problem hiding this comment.
Mi sembra tutto ok, una piccola nota è che potresti aggiungere in questa funzione un controllo per assicurarti che b non sia zero e in quel caso ritornare magari None :)
simone989
reviewed
Nov 9, 2023
| def mul(a: int, b: int)-> int: | ||
| return a*b | ||
|
|
||
| def div(a: int, b:int)-> int: |
simone989
reviewed
Nov 9, 2023
| if b==0: print("The division is not possible") | ||
| else: | ||
| dv= div(a,b) | ||
| print(f"The division is {dv} ") |
There was a problem hiding this comment.
Il controllo se il secondo termine è 0 devi farlo dentro la funzione div, così facendo puoi scrivere un test che verifichi pure quello scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.