feat: Use the Amazon SES API to send mail, for speed and reliability. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SESv2 API calls allow us to send multiple identical emails without using BCC and the API calls are much quicker than routing SMTP via a third party app. It also allow us to use role based authentication on the server, so removes the need to rotate credentials every 90 days. All included settings are defaults, which maintain php mail() for dev environments. Production settings should be injected via Ansible and not read from the site git repo. Refs: OPS-9523
Build outputComposer Validate
|
lazysoundsystem
approved these changes
Oct 30, 2023
Contributor
lazysoundsystem
left a comment
lazysoundsystem
left a comment
There was a problem hiding this comment.
I haven't tested sending mail with this, but it looks okay to me.
… be overridden on prod.
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SESv2 API calls allow us to send multiple identical emails without using BCC and the API calls are much quicker than routing SMTP via a third party app. It also allow us to use role based authentication on the server, so removes the need to rotate credentials every 90 days.
All included settings are defaults, which maintain php mail() for dev environments. Production settings should be injected via Ansible and not read from the site git repo.
Refs: OPS-9523